cljsjs

Hukka 2018-07-11T11:40:14.000072Z

Is it a new norm that cljsjs packages won't be providing via the cljsjs namespace, or just an accidental omission? For example https://github.com/cljsjs/packages/commit/c2a1ba6ade80e8be31196716aa0cc5a515e5c4b3#diff-3e9f409c8bd791752004db5bf19a2beaL35 broke old requires.

juhoteperi 2018-07-11T11:48:49.000006Z

It is normal for new style packages.

juhoteperi 2018-07-11T11:48:59.000097Z

MaterialUI 1 is new package so there shouldn't be lots of old requires around.

juhoteperi 2018-07-11T11:49:34.000108Z

It also broke lots of other things because icons are now separate package etc, so I kind of like that old requires broke

Hukka 2018-07-11T11:50:02.000194Z

It's not so obvious that it's new, since it still has the same name, even if the source is different

Hukka 2018-07-11T11:50:15.000155Z

For example clojars shows it just as a newer version

Hukka 2018-07-11T11:50:52.000050Z

But yeah. I'll just have to figure out how to contact the guy who updated cljs-react-material-ui. He updated the deps, without touching the requires 😕

juhoteperi 2018-07-11T11:51:04.000116Z

cljs-react-material-ui is neever going to work with material-ui v1

juhoteperi 2018-07-11T11:51:08.000194Z

and afaik it is abandoned

Hukka 2018-07-11T11:51:22.000150Z

I was thinking about trying https://github.com/stephenway/cljs-material-ui

juhoteperi 2018-07-11T11:51:51.000281Z

Okay that could work

juhoteperi 2018-07-11T11:52:11.000131Z

At the same time, you can mention that the "usage" section about "I recommend adding this at the beginning of core file" is wrong

juhoteperi 2018-07-11T11:52:41.000184Z

Is is required because reagent ns (https://github.com/stephenway/cljs-material-ui/blob/master/src/cljs_material_ui/reagent.cljs) is broken and doesn't require the cljsjs namespace

juhoteperi 2018-07-11T11:52:54.000260Z

and it might not work in new Cljs/Closure-library

juhoteperi 2018-07-11T11:53:47.000292Z

I've lately worked on refactoring projects from cljs-react-material-ui to just directly calling material-ui through JS interop because the wrapper is unncessary

juhoteperi 2018-07-11T11:53:53.000292Z

but I don't have any public examples yet

Hukka 2018-07-11T11:54:01.000073Z

I think I'll have to go the same route

Hukka 2018-07-11T11:54:07.000258Z

sigh