Clojurians Log v2
Clojure programming
Channels
Apps
cljsjs
jsa-aerial 2018-11-21T02:03:39.017600Z
@miikka Thanks much!!
miikka 2018-11-21T06:53:01.018600Z
@jsa-aerial If you have a patch ready to update vega-embed, please submit a PR and let's merge it.
jsa-aerial 2018-11-21T14:59:11.018900Z
Will do!
jsa-aerial 2018-11-21T15:26:10.019200Z
OK, done and checks pass. But I see that you went ahead and merged the 3.23.1 - I used my fork as updated to latest CLJSJS before that update, so there are 'conflicts' because the version 3.24.1 is being compared to 3.16.1-1 - same with old vega and vega-lite in build.boot.
jsa-aerial 2018-11-21T15:26:22.019400Z
@miikka ^^^
jsa-aerial 2018-11-21T15:34:07.019600Z
OK, in order to prevent this sort of nonsense in the future, I would be willing to be the point person to keep these (the various vega libs) properly updated. I think I saw a place where one can sign up for that but can't find it now. Can you point me to that?
miikka 2018-11-21T16:17:11.019800Z
I don't think that I merged any changes to vega-embed? The boot-cljsjs dependency has been updated and that's why there are the conflicts.
miikka 2018-11-21T16:17:45.020Z
I resolved the conflicts now
miikka 2018-11-21T16:21:58.020400Z
Maybe you meant this? https://github.com/cljsjs/packages/blob/master/CODEOWNERS
jsa-aerial 2018-11-21T16:49:40.020700Z
Yes, that looks like what I meant. So, do I just add stuff to that and give PR for it?
jsa-aerial 2018-11-21T16:50:59.020900Z
OK, sorry, on conflicts it looked like it was complaining about something else - I must have misunderstood. THANKS for the update!