clojars

http://clojars.org discussion and “support”, see http://status.clojars.org for status.
flyboarder 2017-05-05T00:29:08.036763Z

@danielsz I am getting a strange error, could you explain possibly?

danielsz 2017-05-05T02:53:53.725818Z

No, sorry, but then again, I'm not the right person to ask. Maybe @danielcompton?

danielcompton 2017-05-05T02:54:45.729363Z

Looks like it's trying to deploy a .finalized file?

danielcompton 2017-05-05T02:55:23.732651Z

Can you share the full deploy log?

flyboarder 2017-05-05T03:38:48.913556Z

@danielcompton where is the deploy log? or do you mean the stack trace?

danielcompton 2017-05-05T09:54:59.321823Z

@flyboarder all of the logs that were part of your deploy command

danielcompton 2017-05-05T09:55:54.330418Z

but the problem seems to be that you uploaded a .finalized file which had no checksums

2017-05-05T16:01:20.988740Z

@flyboarder hmm, I believe we write a .finalized file to the tmp upload repo, but it should be excluded from the checksum check. I'll take a look

2017-05-05T16:22:57.340338Z

@flyboarder it looks like the cookie store for the aether client is being reused between deploy calls. Are you doing these deploys from a repl?

2017-05-05T16:23:42.352201Z

if the cookies are reused, then the same tmp repo is used, which is what appears to be happening here (all the snapshot deploys are ending up in the same tmp)

2017-05-05T16:24:06.358548Z

not that deploying from the repl is a bad thing, I'm just trying to figure out the cause here

flyboarder 2017-05-05T16:24:30.364769Z

@tcrawley I think you are correct, i have only found reference to this file in the clojars-web repo, and I am deploying from boot continuously

2017-05-05T16:25:02.373159Z

ok, I'll take a look and see what we can do to fix this

2017-05-05T16:25:10.375105Z

I'd like to support that usage

2017-05-05T16:25:39.382860Z

in the meantime, you should be able to deploy by invoking boot from the command-line, if that's an option

flyboarder 2017-05-05T16:27:08.407126Z

yeah it works the first go round, but when the watch task reruns the push command it breaks

2017-05-05T16:28:23.427419Z

and it looks like this only affects snapshots, from looking at the code

2017-05-05T16:29:04.438185Z

ok, I think I see a way to fix it

flyboarder 2017-05-05T16:30:03.454158Z

I have not tried with releases, currently using snapshots as I dont want 50 new releases when im testing the deployment

2017-05-05T16:30:23.460176Z

right :)

2017-05-05T16:30:45.466038Z

actually, this would break with releases as well, now that I'm taking a closer look

flyboarder 2017-05-05T16:31:27.477583Z

oh man I spent all day yesterday making sure it wasnt me causing the propblem XD

2017-05-05T16:32:27.493489Z

sorry about that :(

flyboarder 2017-05-05T17:03:14.970872Z

@tcrawley do you want a github issue?

2017-05-05T17:04:46.994972Z

@flyboarder that would be swell, thanks!

flyboarder 2017-05-05T17:13:07.124004Z

@tcrawley https://github.com/clojars/clojars-web/issues/637

2017-05-05T17:35:29.472325Z

@flyboarder thanks. We have a test that is doing almost the exact thing you are, but it succeeds :( Do you have a locally modified boot.aether or a modified build of pomegranate, perchance?

2017-05-05T17:36:01.480508Z

our test isn't using boot, but our invocation of aether looks the same as boot's

flyboarder 2017-05-05T17:36:48.492913Z

nope! im basically using this build pipeline boot watch build-jar push-snapshot which works without the watch command

flyboarder 2017-05-05T17:37:05.497550Z

but on subsequent deployments it fails with that error

2017-05-05T17:37:33.504603Z

is push-snapshot your task? or is it built-in?

flyboarder 2017-05-05T17:38:11.514666Z

it’s provided by bootlaces, but it’s just a task that collects clojars creds and uses the built-in push task

2017-05-05T17:38:47.523772Z

yeah, that does nothing special

2017-05-05T17:38:52.525033Z

hmm

flyboarder 2017-05-05T17:39:10.529634Z

I tracked the trace stack down to the aether/deploy call

flyboarder 2017-05-05T17:39:25.533262Z

so i thinks it’s the server

2017-05-05T17:39:57.541653Z

yes, definitely, we have a bug. I just want to add a test for it, so I know when I've fixed it/break it in the future

2017-05-05T17:40:27.549781Z

basically, I need to figure out how to get aether/deploy to reuse a cookie store between calls

2017-05-05T17:40:53.556572Z

we do multiple deploys in the same test, but it doesn't share the cookies

2017-05-05T17:41:01.558657Z

but does under boot, apparently

flyboarder 2017-05-05T17:42:24.580128Z

that makes sense since the worker pod is constructed only once when the task it built

2017-05-05T17:44:41.615197Z

I agree, except two aether/deploy calls right after each other in the clojars tests don't share :(

flyboarder 2017-05-05T18:22:13.201945Z

@tcrawley I fixed it by monkey-patching the push task, now uses a new pod each time the task runs, fixed the issue!

2017-05-05T18:22:36.207465Z

heh, "fixed".

2017-05-05T18:23:08.216200Z

good deal. I may have you unfix it and try after I push a fix if you are cool with that

flyboarder 2017-05-05T18:24:00.229749Z

yep, I’m not submitting the patch up to boot, instead im including it with my custom task

2017-05-05T18:24:12.232911Z

coolio