Clojurians Log v2

@borkdude @danielcompton I recently updated the clojars shields badge

You can see why this is happening by checking the api data

https://clojars.org/api/artifacts/finitize

The new badge uses the api endpoint and the “latest_release” property

if you want to use the snapshot version, you have to explicitly tell shields to use pre release versions which uses the “latest_version” property instead

Change your current badge url from

<https://img.shields.io/clojars/v/finitize.svg>

<https://img.shields.io/clojars/vpre/finitize.svg>

ie. nothing wrong with clojars

Ah, thanks!

Let’s take a step back and see how I got here. I just copy paste the “Version badge” code from Clojars and assume this will work. https://www.dropbox.com/s/99xrqr0np0htzqy/Screenshot%202019-03-10%2009.38.32.png?dl=0

And I could have sworn this used to work for my snapshot-only project before. The “invalid response data” message in the badge is new at least for me.

anyway, I’ll update it now I know what to do. thanks

@borkdude yes that would have worked for snapshot only projects prior to the recent updates

where was something updated?

I mean, what is “the recent updates”?

@borkdude https://github.com/badges/shields/pull/3128

ok, so this basically broke my working badges… which now requires to be changed?

If your project has SNAPSHOT only versions then yes, you will need to update the badge url, nothing changes for projects with existing stable releases

I read in the issue: > Updates version endpoint which will always return latest stable version or snapshot if no stable versions are available.

Yeah, we had to change that while refactoring the clojars class used to generate the badges

I updated my comment to remove that part

I mean, apparently the last bit isn’t working anymore?

Correct, I had to remove that part since there is no longer common code between the release and snapshot badge

why not fall back to latest_version if latest_release is null here? https://github.com/flyboarder/shields/blob/e9ebdbedb79767cc5ee39576a5e071d7c31c438c/services/clojars/clojars-release.service.js#L8

@borkdude I just put a new fix forward!

cool thanks 🙂