Clojurians Log v2

OK, with these changes: https://github.com/clojure/clojure/compare/master...borkdude:map-optimizations And this benchmark:

clj -Sdeps '{:deps {org.clojure/clojure {:mvn/version "1.11.0-master-SNAPSHOT"} criterium/criterium {:mvn/version "RELEASE"}}}'
user=> (use 'criterium.core)
nil
user=> (defn merge-benchmark [size] (let [m1 (zipmap (range size) (range size)) m2 (zipmap (range size (* 2 size)) (range size (* 2 size)))] (println (type m1) (type m2)) (quick-bench (merge m1 m2))))
#'user/merge-benchmark

Here’s a gist with the exact numbers: https://gist.github.com/borkdude/b6e52bc1bd32512aa43015724cda46da

so for a 2000 element map it would mean a speedup of 35%

small maps are super common tho, ex ring

yeah. maybe a count on the seq before doing the optimization would make sense?

or we could just decide that this is not worth optimizing. chances are that Rich has already thought about this case

for PersistentArrayMap the override could be removed since those are small maps all the time

The solution with counting up front makes it slower in all cases. So the trade off is to optimize for big maps (> 64) or smaller maps (< 64). I guess it’s very common to have small maps in Clojure, hence the optimization is probably off the table.

People using big maps can write their own transient merge probably