clojure-dev

Issues: https://clojure.atlassian.net/browse/CLJ | Guide: https://insideclojure.org/2015/05/01/contributing-clojure/
alexmiller 2019-09-17T00:42:21.012500Z

yes

alexmiller 2019-09-17T01:41:01.012900Z

contrib builds poll hourly btw

2019-09-17T01:41:58.013400Z

Hey, only my wife is allowed to read my mind! 🙂

alexmiller 2019-09-17T01:44:54.013800Z

I can sense your thoughts

alexmiller 2019-09-17T01:45:15.014Z

but I can poke it for you if you like

alexmiller 2019-09-17T01:45:27.014200Z

poked!

2019-09-17T01:52:59.014600Z

thanks. I can see already I have broken some tests -- will fix soon

alexmiller 2019-09-17T02:14:25.014900Z

seems like something to do with running the cljs tests?

alexmiller 2019-09-17T02:15:01.015400Z

let me know if you end up needing to change the minimum clojure version or whatever, that's in the build infrastructure

2019-09-17T04:51:41.015600Z

most likely a missing file.

2019-09-17T04:51:44.015800Z

added now

2019-09-17T05:36:48.016900Z

There is nothing urgent about this, but it appears that contrib builds are not triggered each hour by commits. I do not know why, but wonder whether the error message on the "Git Polling Log" link is relevant: https://build.clojure.org/job/core.rrb-vector/scmPollLog/

alexmiller 2019-09-17T12:07:11.017500Z

Definitely relevant, will take a look

alexmiller 2019-09-17T18:36:34.018400Z

yeah, that has been broken for a while apparently. made a whole bunch of job template updates and pollers are working now (which means everything has decided to rebuild)

2019-09-17T18:40:03.019100Z

Yep, and thanks for the fix. I can try rerunning core.rrb-vector tests when those get run through.

alexmiller 2019-09-17T18:55:41.019400Z

might be a while

alexmiller 2019-09-17T18:56:52.019800Z

it did get re-run this morning btw and failed https://build.clojure.org/job/core.rrb-vector/442/console

alexmiller 2019-09-17T18:57:12.020100Z

which seemed like a pretty weird error

alexmiller 2019-09-17T18:57:56.020600Z

looks like the cljs tests are using clojure 1.5.1 though which seems wrong?

2019-09-17T19:23:04.022600Z

The pom.xml and project.clj files both depend upon Clojure 1.5.1 as the minimum Clojure version supported. Michal expressed a preference to keep working with that version of Clojure if possible, but perhaps I can at least disable running cljs tests with Clojure versions older than 1.8.0 or so.

2019-09-17T19:23:41.023100Z

I'm still pretty new to the various ways of running ClojureScript tests, so will be hacking and experimenting for a bit.

alexmiller 2019-09-17T19:59:06.024900Z

fyi, the build box will no longer test anything older than Clojure 1.6.0, just no reason to do so based on usage in the Clojure survey (and many now require at least 1.7.0)

alexmiller 2019-09-17T20:00:43.025300Z

as of the last survey, only 3% were using 1.7 or earlier

2019-09-17T20:17:29.025800Z

I know. I'm not the one with the preference for preserving working with the older Clojure versions 🙂

2019-09-17T20:19:02.026700Z

I will try bumping up Clojure version in pom.xml to 1.6.0 and see what happens. I don't see failures like that with similar mvn command run on my Linux machine, so not sure why that happens.

alexmiller 2019-09-17T20:19:23.027100Z

do you have any cljc? that didn't exist until 1.7

alexmiller 2019-09-17T20:20:02.027800Z

if you need my help debugging anything, let me know. I can actually ssh into the box and do a lot more

2019-09-17T20:29:16.028500Z

There are no cljc files in that project. It has supported Clojure 1.5.1 since it was created, and I have added no cljc files to it yet.

2019-09-17T20:37:50.029500Z

Bumping clojure dependency in core.rrb-vector's pom.xml up to 1.6.0 instead of former 1.5.1 seemed to help build go better on http://build.clojure.org just a few mins ago, which is good. Cool.

2019-09-17T21:22:22.031100Z

And now the whole core.rrb-vector test matrix is good on http://build.clojure.org, with running the built-in clj and also cljs tests on the build box. (it actually throws and catches an expected exception for the cljs tests for clj < 1.8 or jdk < 1.8, which matches what data.xml library does there, too).

2019-09-17T21:22:39.031400Z

Thanks for the help, Alex! I will go break some things now.

alexmiller 2019-09-17T21:25:20.031600Z

sounds good :)

alexmiller 2019-09-17T21:25:36.032Z

if you need help with a release eventually, let me know

2019-09-17T21:42:58.033200Z

Will do. Probably a week or so.