Clojurians Log v2

As ring is heading towards using namespaced keys in request & response maps (https://github.com/ring-clojure/ring/issues/393), is there a plan to support namespaces keys with records?

I guess the lookups for unqualified & qualified keys from maps should have about the same performance?

a quick test for a field lookup for a ring-request map (14 keys) using: 1. qualfied key 24ns 2. unqualified key 20ns 3. record with unqualified key 4ns

if not record, maybe some new map-like type which would enable fast lookups with known qualified keys?

given how much things get added to request maps, I don't think records are necessarily a good choice anyways - changing a record means instantiating a new record

there are many ways request maps are used - focusing only on key lookup performance is missing other parts of the picture

it seems weird, but you may actually want to look at struct-maps

although I'm not sure struct-maps support ns'ed keys well either, I don't know if I've ever used them

a customized map-like data structure optimized for known usage patterns may make sense here. I don't know that records are the right answer. getting a clearer picture for the operations and their frequency is the first step though

changing a record means instantiating a new record how's that different from changing a map?

perf differences of copying an array vs accessing all of a record's fields?

yeah, it's at least something that should be considered

makes sense

@alexmiller dunno if you get notified about jira comments (I don't anymore), but resolve introduces a bug

if we don't want to open up the compiler, we could do it in a similar way as we do it for defn

(if (clojure.lang.Util/equals nil (clojure.lang.Compiler$HostExpr/maybeSpecialTag tag))
                                (let [c (clojure.lang.Compiler$HostExpr/maybeClass tag false)]

you should get notified, but some of the "created by"/"updated by" metadata was broken in the migration - by default you should get notified if you created it, are watching, or voted for it

what's the bug?

user=> (defprotocol p (^longs f [_]))
p
user=> (set! *warn-on-reflection* true)
true
user=> (defn foo [x] (aget (f x) 0))
Syntax error (IllegalArgumentException) compiling . at (REPL:1:15).
Unable to resolve classname: #'clojure.core/longs

sorry, you prob put it on the ticket

seems like there should be tests to expose this

see -4

I may not receive the emails I care about anymore, but Atlassian makes sure I get those sweet sweet spam ones :)

is it possible to go back to receiving emails about issues created on my projects? I looked everywhere and couldn't find how to

I can probably fix that, will look at it later

ty

I've updated the notification scheme both for your projects and many others to have project lead notification like we had on the old jira

I looked at your settings and some of the project settings. in general, you should receive updates if a) you reported the issue, b) you are the assignee, or c) you are "watching" the issue. Now, in the projects where you are a lead, you should also get updates on issues in your projects.

if you find a specific issue and a specific event that you don't get an email for, let me know and they have a tool that can use all that info and tell me what notifications you should get and why