clojure-dev

Issues: https://clojure.atlassian.net/browse/CLJ | Guide: https://insideclojure.org/2015/05/01/contributing-clojure/
dpsutton 2020-07-11T17:47:37.371400Z

Random aside, I see the two doc strings for clojure core:

(ns ^{:doc "The core Clojure language."
       :author "Rich Hickey"}
  clojure.core)
and then later its updated (alter-meta! (find-ns 'clojure.core) assoc :doc "Fundamental library of the Clojure language") Does anyone remember a reason behind this?

seancorfield 2020-07-11T17:57:16.371800Z

This is the commit that added it https://github.com/clojure/clojure/commit/21caa3eb5

seancorfield 2020-07-11T17:59:23.372300Z

Here's where the top docstring was added -- later https://github.com/clojure/clojure/commit/76e7c4317

dpsutton 2020-07-11T17:59:48.372800Z

was just typing that up. it says fixes two tickets. i'll look into that in a bit

seancorfield 2020-07-11T18:02:16.374400Z

So the alter-meta! version came first, in January, then the :doc / :author metadata was added in December. So I guess that reflects how support for metadata and docstrings in namespaces evolved. Interesting to see...

dpsutton 2020-07-11T18:04:46.374600Z

so important its documented twice πŸ™‚

seancorfield 2020-07-11T18:08:41.375400Z

#216 seems to be unrelated -- I guess Stuart was really fixing #217 (and perhaps just didn't notice the alter-meta! near the bottom?)

alexmiller 2020-07-11T18:10:00.376Z

Might have had to do with something about autodoc too

alexmiller 2020-07-11T18:10:23.376700Z

There used to be a bug that meta on namespaces would not end up in aot compiles classes

alexmiller 2020-07-11T18:10:56.377400Z

And that affected what autodoc (which relies on loading) could see

alexmiller 2020-07-11T18:11:13.377800Z

That bug was fixed around 1.6

seancorfield 2020-07-11T18:12:23.378300Z

These changes were back in 2009, which is 1.1 / 1.2 time?

seancorfield 2020-07-11T18:12:38.378700Z

(I'm murky on pre-2011 stuff πŸ™‚ )

seancorfield 2020-07-11T18:13:58.379700Z

1.0 was May 2009 (after the alter-meta! change to add ns metadata). 1.1 was December 2009 just after the addition of :doc / :author to all core namespaces.

seancorfield 2020-07-11T18:18:34.381700Z

So I guess my first exposure to Clojure was on 1.1 after all (about May 2010, when I took Amit Rathore's workshop). And the 1.3 pre-release process was longer than I remembered -- we went to production on 1.3 alpha 7 or 8 I think in spring 2011 roughly and the gold release wasn't until September that year. Ah, simpler days... πŸ™‚

2020-07-11T23:18:23.382100Z

but...there's no good reason for the two to be different, right?

seancorfield 2020-07-11T23:20:08.382500Z

Not that I can think of. Jira and patch welcome, I suspect?

alexmiller 2020-07-11T23:33:30.383300Z

I can’t imagine Rich really cares enough to make that worth it

2020-07-11T23:43:45.383600Z

there should be an "Alex Miller says this is trivial" loophole

alexmiller 2020-07-11T23:45:39.384300Z

It only opens for 12 minutes under every 9th full moon

2020-07-11T23:46:29.384500Z

man that sounds like a fun time

2020-07-11T23:47:13.384800Z

"How many tabs will I get to convert to spaces this year???"

πŸ‘Ύ 1
seancorfield 2020-07-11T23:54:36.385700Z

I guess it would take longer to agree on which docstring should remain than it would to actually remove that one line (and maybe change the other) πŸ™‚