Clojurians Log v2
Clojure programming
Channels
Apps
clojure-dev
Issues: https://clojure.atlassian.net/browse/CLJ | Guide: https://insideclojure.org/2015/05/01/contributing-clojure/
mpenet 2021-02-22T15:58:21.001900Z
shouldn't assert docstring make explicit the fact they will cause Errors to be thrown and not exceptions?
mpenet 2021-02-22T15:58:24.002100Z
https://github.com/clojure/clojure/blob/clojure-1.10.2/src/clj/clojure/core.clj#L4806-L4807
mpenet 2021-02-22T15:58:43.002700Z
the docstring is just wrong it seems in master
mpenet 2021-02-22T15:59:05.003Z
not an Exception -> https://docs.oracle.com/javase/7/docs/api/java/lang/AssertionError.html
mpenet 2021-02-22T16:03:26.003300Z
I can send a patch if you'd like
mpenet 2021-02-22T16:10:53.003700Z
actually there's already https://clojure.atlassian.net/browse/CLJ-2225
alexmiller 2021-02-22T16:26:51.004Z
https://ask.clojure.org/index.php/4645/clojure-core-assert-docstring-is-incorrect is the best place to vote
alexmiller 2021-02-22T16:27:40.004700Z
here, I read exception (lower case e) as any kind of exception, not necessarily as "subclass of Exception"
alexmiller 2021-02-22T16:28:13.005100Z
but I'm on board with making it more precise
alexmiller 2021-02-22T16:29:28.005800Z
we look at bugs based (at least in part) on the number of votes on ask.clojure
2021-02-22T17:20:31.006200Z
Are Errors subclasses of Exception?
2021-02-22T17:21:15.006600Z
Looks like it’s its own branch under Throwable.
2021-02-22T17:21:43.006900Z
Ah > not necessarily as “subclass of Exception” Misread that bit.
borkdude 2021-02-22T17:22:00.007100Z
Seems not:
user=> (.isAssignableFrom Exception Error)
false
user=> (.isAssignableFrom Error Exception)
false 2021-02-22T17:22:55.007300Z
Voted 🙂