Clojurians Log v2

The most annoying thing is when I make a simple example to see where it breaks down it works fine.

the data-spec is not safe as it mutates the global registry. If you have two documents with different min & max, the last one overrides the first.

How did you make it work @matti.uusitalo?

I'm trying to spec a large, complicated map for a bunch of game data. there are several possible states the game might be in, and the fields vary depending on which state we're in. I want a spec something like (s/def ::state-pregame (s/merge ::state-core (s/keys pregame-specific-things) {::state :states/pregame}))

where the key is that last bit, specifying a particular key and value pair for the pregame state.

oh, TIL about multi-spec, which is exactly this.

Yes, you have to be careful to not use data-spec for multiple documents at once. Sometimes it is an acceptable trade-off.

I'm not seeing a way around it if you want to use s/keys and the global registry. It does not make sense to me to define a spec on the global keyword ::values that is specific to a given map. The contract that the integers in ::values must be between :min and :max is a property of the map, not the global ::values keyword. If you still want to benefit from the s/explain infrastructure, you can always write a "local spec" like this:

(defn validate-map
  [{:keys [min max values] :as data}]
  (let [s (s/coll-of (s/int-in min max))]
    (when-not (s/valid? s values)
      (throw (ex-info "Invalid map."
                      {:explain (s/explain-data s values)})))))