cloverage

https://github.com/lshift/cloverage/issues/103
lvh 2016-10-08T13:42:26.000047Z

@rhu So I did that and my immediate reaction was that that might be a bad idea

lvh 2016-10-08T13:42:31.000048Z

because we have outstanding PRs

lvh 2016-10-08T13:43:03.000049Z

so now junit xml support doesn’t merge cleanly, prelim boot support doesn’t, and neither does the for loop chunked seq thing

lvh 2016-10-08T13:43:28.000050Z

any preferences moving forward? I’d like to get those in somehow, ideally without asking the contributors to do even more work

2016-10-08T13:59:41.000051Z

I don't mind mopping up the merge conflicts

2016-10-08T14:01:27.000052Z

Only this one is squealing about merge conflcts though: https://github.com/cloverage/cloverage/pull/127

2016-10-08T14:09:06.000054Z

Presume you'll need to give me write access do that though ?

lvh 2016-10-08T15:29:02.000056Z

Yeah, I’m happy to give you write access but I’m not sure how that’ll help

2016-10-08T15:45:18.000057Z

thought maintainers could now edit PRs ?

lvh 2016-10-08T15:53:11.000058Z

I can edit the title, but not the source branch

2016-10-08T15:53:38.000059Z

the loop chunked PR will merge cleanly but will fail travis because of the formatting rules,

2016-10-08T15:54:14.000060Z

Boot support will merge cleanly and travis passes

2016-10-08T15:54:39.000061Z

junit support has some merge conflicts

lvh 2016-10-08T15:55:44.000062Z

I mean, you could pull the branch and open a new PR

lvh 2016-10-08T15:55:59.000063Z

that is what I understood the procedure to always be for GitHub

2016-10-08T15:58:26.000064Z

how close do you think those PRs are to be merged into master?

2016-10-08T15:59:29.000065Z

when I said give me write access, i would’ve checked out locally, fixed the conflicts then pushed to master

2016-10-08T16:00:04.000066Z

but if the PRs are not quite ready, theres not point in doing that

lvh 2016-10-08T17:04:13.000067Z

I think they’re good to go

lvh 2016-10-08T17:04:18.000068Z

I just wanted a release I can trust

lvh 2016-10-08T17:04:28.000069Z

due to the lack of releases, a lot of people are running -SNAPSHOT

lvh 2016-10-08T17:04:50.000070Z

and some of these changes are benign, but the :for one might actually break something