Clojurians Log v2

@kamillelonek: May be https://www.jetbrains.com/upsource/ will fit your needs? I have no experience with that, but JetBrains usually make good tools.

thanks

I'll check that

@kamillelonek: I’ve had great results with Gerrit for code reviews, but it’s a little bit more heavyweight than a one-off code review. gerrithub is free for OSS

I was thinking about something small, gerrit is quite big as I've tried it

@kamillelonek: Maybe http://codebrag.com/ ?

still, it need to be self hosted 😉

@kamillelonek: it is, it's downloadable

seriously, I need a dead simple solution, something like GitHub gists, but with better commenting options, I'll stick to gists for now, but in case I find something I'll post it here

@kamillelonek: oh crap, I got it backwards, sorry

may I ask for a code review: https://gist.github.com/KamilLelonek/304699d8803e699bfd45

@kamillelonek: I would be careful of your naming, and try to make it a bit clearer -> declaring github-user-public-keys-url as a def but also in the parameter of a function for instance. Think about namespaces too, eveything in here is specific to github so I wouldn’t have github in all the defn’s.

@kamillelonek:

(defn github-user-public-keys-json [github-user-public-keys-url]
  (json/read-str (github-user-public-keys-response github-user-public-keys-url) :key-fn keyword))

(defn github-user-public-keys-json [public-keys-url]
  (let [response (response-body public-keys-url) ]
    (json/read-str response :key-fn keyword)))

github-user-public-keys-response makes more sense becoming response-body, and it is then re-usable and it doesn’t matter what you give to it (within reason)

ok, your points are very valid

thank you for the input

You’re welcome :simple_smile: feel free to come back for further input after you have made changes

I am not sure If json should be in the function also, as it is implied that json will be returned. Which it will not.

perhaps public-keys-for-user and then pass a username in rather than the whole url.

@gjnoonan: what do you think now: https://gist.github.com/KamilLelonek/304699d8803e699bfd45?

@kamillelonek: Sorry for the late reply, better, but still watch out for your naming.

(defn- all-members-json []
  (:body (all-members-response)))

(defn- all-members-public-keys-urls []
  (map github/member-public-keys-url (all-members-logins)))

> Sorry for the late reply

I'm so grateful you are helping me at all

I don't even expect to have an immediate response

in the first case when I'm using json is to distinguish function name from the other one without json

it's not needed at all, but I don't have a better name, all-members already exists

naming is kinda hard for me, when I come from OO where it was easier to have objects and name their methods

especially naming modules and namespaces is what I'm still getting used to

Which is why I think something like a response-body function, which grabs the body of any response you pass into it may be a better option.

member-public-keys-with-id wheres the id from? does it take an id or is it returned with an id?

hm, it returns id as well

is this always going to be used just for getting public keys?

yes