code-reviews

2015-11-29T22:51:34.000011Z

Wrote my first bit of code in Clojure—a 50 LOC scraper—would love feedback on it :simple_smile: x-posted in #C053AK3F9 Code: https://gist.github.com/revivek/d6559b3fd5b9f661e095 Output (pprinted): https://gist.github.com/revivek/2f61bb8a1fe3311377ea

martinklepsch 2015-11-29T23:02:08.000012Z

@revivek: consider map literals instead of hash-map

martinklepsch 2015-11-29T23:04:03.000013Z

@revivek: also check partition vs partition-all

martinklepsch 2015-11-29T23:08:52.000014Z

@revivek: (:require …) can contain multiple namespace requires

martinklepsch 2015-11-29T23:10:09.000015Z

@revivek: use of dynamic vars seems unnecessary

martinklepsch 2015-11-29T23:10:36.000016Z

(sorry for being so brief, typing w/ one hand :simple_smile:)

2015-11-29T23:13:17.000018Z

@martinklepsch: super helpful—thank you!