code-reviews

roelofw 2016-12-09T08:50:46.000181Z

@gdeer , pushed all the changes with credit to you

😊 1
gdeer81 2016-12-09T17:09:02.000185Z

neat

roelofw 2016-12-09T18:35:12.000187Z

Did some changes to read-numbers so I could test it

roelofw 2016-12-09T18:35:41.000188Z

I think in a few days I push a version with test with clojure.test

roelofw 2016-12-09T18:36:40.000189Z

@gdeer81 : found issues or is everything well now /

gdeer81 2016-12-09T18:42:46.000190Z

Sorry had a production deployment last night so I didn't get a chance to keep digging

roelofw 2016-12-09T18:43:31.000191Z

NP

roelofw 2016-12-09T18:43:42.000192Z

work is more important

roelofw 2016-12-09T18:44:13.000193Z

just like private life is more important then work is my oponion

roelofw 2016-12-09T18:46:56.000194Z

@gdeer81 what do you use for testing ? spec/midje/clojure.test ?

gdeer81 2016-12-09T19:10:11.000195Z

my new years resolution is to use spec and generative testing

gdeer81 2016-12-09T19:11:25.000196Z

As a beginner it's important to try em all 🙂

roelofw 2016-12-09T19:23:25.000197Z

I think you are not a beginner anymore

roelofw 2016-12-09T19:23:30.000198Z

you know more then me

gdeer81 2016-12-09T19:26:56.000199Z

I'm currently trying to get passed being an advanced beginner and avoid being an expert beginner http://daedtech.com/pics/ExpertBeginner.jpg

agile_geek 2016-12-09T19:28:00.000201Z

@gdeer81 I think I may be stuck in that expert beginner cul-de-sac!

agile_geek 2016-12-09T19:28:53.000202Z

P.S. not sure many ppl ever get to expert...been a Java dev for 19 years and I'd only count myself as proficient!

gdeer81 2016-12-09T19:30:23.000203Z

@agile_geek that is why I think it is really important for everyone at every level to have a mentor. guiding someone helps reinforce what you know and working with someone that knows more than you will help you learn new things

👍 1
agile_geek 2016-12-09T19:32:03.000204Z

I would agree and add that working with someone with less experience helps me learn as I'm often forced to rethink assumptions or build a different mental model in order to explain something.

roelofw 2016-12-09T19:37:58.000205Z

I think im still a novice

roelofw 2016-12-09T19:38:25.000206Z

still a lot to learn

roelofw 2016-12-09T19:39:01.000207Z

and right now learning gets in a very low pace

roelofw 2016-12-09T19:39:16.000208Z

it costed me a whole afternoon to make one test

roelofw 2016-12-09T19:42:02.000209Z

I think it will cost me a few months to go to the next level

roelofw 2016-12-09T20:17:46.000210Z

maybe do some more work on my project and maybe continue with 4 clojure or another practice site

roelofw 2016-12-09T20:18:31.000211Z

@agile_geek @gdeer81 Sounds like a good plan ?

agile_geek 2016-12-09T20:19:22.000212Z

Yeah, I think learning in different ways is useful.

roelofw 2016-12-09T20:19:56.000213Z

I can make a detail page where the painting is shown and some data under it

gdeer81 2016-12-09T20:20:12.000214Z

let your project rest if there aren't any show-stopping defects, do another project or do some problems and then come back to your project later with a new set of eyes

roelofw 2016-12-09T20:20:15.000215Z

I can make more tests with first clojure.test and maybe later spec

gdeer81 2016-12-09T20:20:30.000216Z

adding tests are good as well

roelofw 2016-12-09T20:21:25.000217Z

Another project I have to think well, My ultimate project is making a sort of accounting site but that is too far away for now

gdeer81 2016-12-09T20:22:16.000218Z

here is one that is a little more involved than 4clojure problems but it won't be too involved that you couldn't finish it: https://stanfordclojure.com/#/assignments/pset1

roelofw 2016-12-09T20:35:56.000219Z

oke, one problem did I see earlier

roelofw 2016-12-09T20:36:15.000220Z

I think I cannot email the solutions like the page said @gdeer81 ?

gdeer81 2016-12-09T20:36:50.000221Z

no, just do the solution and then you can post your repo in this channel

roelofw 2016-12-09T20:37:26.000222Z

oke, that I can also do

roelofw 2016-12-09T20:37:39.000223Z

the first is the same as a challenge for 4clojure

roelofw 2016-12-09T20:41:51.000224Z

@gdeer81 I do not know how many time it costs to solve all the challenges

gdeer81 2016-12-09T20:44:14.000225Z

yeah I'm still not finished with the 4clojure problems. I like to mix it up , so I go back and forth between puzzles and projects

roelofw 2016-12-09T21:17:58.000227Z

I m was "leaving" 4 clojure on the same problem as the first one of the stanford challenges

roelofw 2016-12-09T21:18:12.000228Z

So it will be hard for me, but that is allright

roelofw 2016-12-09T21:27:13.000229Z

@gdeer81 I think I can solve it with some but I have to think about the predicate

roelofw 2016-12-09T21:27:40.000230Z

I think I can use something like true?

gdeer81 2016-12-09T21:28:42.000231Z

post the question and your proposed solution in refheap https://www.refheap.com/

roelofw 2016-12-09T21:29:06.000232Z

because this is giving the wrong answer

(some true? [true true true]) 

gdeer81 2016-12-09T21:29:09.000233Z

that way someone that doesn't have the context of our conversation can review it as well

roelofw 2016-12-09T21:29:29.000234Z

it gives true where it must be false

roelofw 2016-12-09T21:30:26.000235Z

and this one ` (some true? [false false false]) ;;=> nil ` gives nil where it schould be true

roelofw 2016-12-09T21:31:15.000236Z

the exercise is this

Problem 1
Write a function which takes a variable number of booleans. Your function should return true if some of the parameters are true, but not all of the parameters are true. Otherwise your function should return false. For example:
(= true (half-truth true false))
(= false (half-truth true true))  

roelofw 2016-12-09T21:31:27.000237Z

next time I will use refheap

roelofw 2016-12-09T21:32:14.000238Z

I will sleep about it . it's almost 11 hour in the evening

gdeer81 2016-12-09T21:33:01.000239Z

think about what some does and what the problem is asking

roelofw 2016-12-09T21:34:14.000240Z

I will do that

roelofw 2016-12-09T21:34:28.000241Z

Good night from a cold Netherlands