Clojurians Log v2

Site is ready. Code : https://github.com/rwobben/paintings

the layout can be see here : https://lit-lowlands-46138.herokuapp.com/

@roelofw Something non clojure specific. Its better to ignore the .idea folder and *.iml files. Or any other IDE specific stuff. This should be generated by the build tool or handled by the IDE itself.

oke, I will change that

I know I can do that with git ignore file

I do not know if these folders get deleted the next time I put them in the ignore file

You have to remove them from git explicitly, once they were added, even after adding them to the .gitignore file. The same goes for profiles.clj which explicitly states it should be in .gitignore in its comment.

do-both-in-parallel-detail what is both? The name could be better

oke, done with deleting the files from github

the function takes care that both files are executed in parallel

Try to express what the function does in the name. Also do not express how the function does that (parallel or not is an implementation detail which does not belong into the function name)

oke, I will try to make up a better name

any recommendations?

Also any log file does not belong into source control

and the log itself not into the "src" folder

maybe fetch-paintings-and-images

nice idea

changed it also

In general format the whole file and remove the empty lines at the end of the file

closing parantheses belong to the end of the line and not on the next line

@sveri which file are you talking about

https://github.com/rwobben/paintings/blob/master/src/clj/paintings2/api_get.clj

https://github.com/rwobben/paintings/blob/master/src/clj/paintings2/api_get.clj#L66

changed that

the reformat I let cursive do the formatting

did you commit already?

nope, I busy with some reformatting

ok

now committed

If you have more feedback then I will read it tomorrow. Now time to sleep

Thanks a lot for the feedback

Yea, for me too, have a nice day 🙂

night 😄

I wish you the same

and I hope your are satisfied how I deal with your feedback

hehe, its not about me. You should be satisfied with yourself 😉

of course, but it is always good to see that some one is doing something with the remarks you made