code-reviews

agile_geek 2016-12-21T08:27:07.000680Z

@roelofw re: formatting - this is a useful lein plugin to reformat all your code https://github.com/weavejester/cljfmt

sveri 2016-12-21T08:34:22.000682Z

@roelofw the file is still ill formatted: https://github.com/rwobben/paintings/blob/master/src/clj/paintings2/api_get.clj#L69

sveri 2016-12-21T08:34:42.000684Z

and it still has the empty lines at the end l.83 - 92

agile_geek 2016-12-21T08:39:49.000685Z

@roelofw are you using this? https://cursive-ide.com/userguide/formatting.html

roelof 2016-12-21T12:11:03.000689Z

@agile_geek yes, that is the ide I use at the moment

roelof 2016-12-21T12:12:54.000690Z

Does cursive not do a good job at formatting my code ?

agile_geek 2016-12-21T12:17:04.000691Z

Not if it's leaving hanging parenthesis on the next line. Are you actually using Ctrl (or Cmd if it's a Mac) Alt L to make Cursive reformat?

roelof 2016-12-21T12:30:54.000692Z

yep , I use the Ctrl - Alt - l for reformatting

sveri 2016-12-21T13:00:25.000693Z

@roelof You should switch to Parinfer

sveri 2016-12-21T13:00:35.000694Z

it does not even allow putting parantheses on the next line

roelof 2016-12-21T13:06:11.000695Z

I tried that a few times but then I could not make functions work on repl

roelof 2016-12-21T13:06:21.000696Z

so I switched that off

sveri 2016-12-21T13:07:17.000697Z

@roelof Hm, I am not sure what one has to do with the other?

roelof 2016-12-21T13:07:35.000698Z

I also not

roelof 2016-12-21T13:08:15.000699Z

but when I do ( in repl, its makes a closing ) which gets overwritten when I try to make a function

sveri 2016-12-21T13:08:58.000700Z

Yes, parinfer automatically adds parantheses. I would suggest to learn to handle these. In the long run it makes editing clojure code easier.