code-reviews

freekpaans 2017-04-05T11:27:07.872959Z

hi all, i'm looking for feedback on a project i recently open sourced. anyone interested?

sveri 2017-04-05T12:08:59.372257Z

@freekpaans It would be useful to link the project, so people can see what its about

freekpaans 2017-04-05T12:09:26.378002Z

alright, it's here https://github.com/infi-nl/alibi

sveri 2017-04-05T12:21:42.538134Z

@freekpaans The first thing that comes to my mind is if you enforce a coding style and automatically reformat your files?

freekpaans 2017-04-05T12:22:19.546344Z

@sveri you mean if i have that enabled?

sveri 2017-04-05T12:22:32.549305Z

yes and if you use it

freekpaans 2017-04-05T12:23:06.556743Z

not a separate tool, but i let vim do it

sveri 2017-04-05T12:23:55.567345Z

Ah ok, I was just confused by the linebreaks in the require expression: https://github.com/infi-nl/alibi/blob/master/src/alibi/web.clj#L6

sveri 2017-04-05T12:24:00.568436Z

as long as its conistent

freekpaans 2017-04-05T12:25:03.582353Z

ah, that's because i try to keep things within 80 chars

freekpaans 2017-04-05T12:25:37.590014Z

though that line would pbb have fit 🙂

sveri 2017-04-05T12:29:03.637141Z

For me personally 80 lines is to short, but, I usually write Java 😄 Anyway, a tool should do that automatically in an ideal world, cursive does it not and I dont know if any other does that

2017-04-05T13:32:44.717699Z

@freekpaans add js-joda to cljsjs?

2017-04-05T13:33:14.727580Z

and why do you need it, just curious why moment.js isn't enough.

freekpaans 2017-04-05T13:42:44.922212Z

i like the joda time apis, and momentjs is mutable iirc

freekpaans 2017-04-05T13:44:10.951931Z

adding js-joda to cljsjs is on my list 🙂

2017-04-05T15:11:19.016287Z

if joda-time makes time immuteable, then I need it on the weekends 🙂

slipset 2017-04-05T17:00:41.519771Z

There is of course cljs-time