code-reviews

2018-10-15T16:35:04.000100Z

@dazld you don't actually need a stop channel - if you use a channel you should be checking if it is closed, and that should be an exit condition from your loop

2018-10-15T16:36:07.000100Z

also, binding the go-loop to _ is strange, because you could just move it into the let body (let has an implicit do, accepting any number of forms for side effects

2018-10-15T16:37:15.000100Z

also, there's no way for anything to use the vals that get accumulated

2018-10-15T16:38:06.000200Z

with a small refactor, you could return them when stop is invoked

2018-10-15T17:13:27.000100Z

also, if action is blocking or CPU intensive, you should use core.async/thread and then use <! to park on the thread's completion