code-reviews

dazld 2018-10-23T12:29:18.000100Z

thanks for that feedback and review - we went through it and it ended up much simpler - https://github.com/dazld/batches

2018-10-23T16:39:32.000100Z

@dazid if some other code closes the in channel, your code will go into a fast loop repeatedly accumulating nils in your vector

2018-10-23T16:40:02.000100Z

there's also a problem of writing to out after it's closed, but the misbehavior is less serious