code-reviews

2018-11-02T02:52:19.001400Z

It would be great to have code review on this PR https://github.com/LeandroTk/pokemon/pull/1

2018-11-02T02:52:43.002Z

I'm learning threading to compose functions, but I don't know if this is the best way to it

seancorfield 2018-11-02T03:22:49.003Z

You could do most of that with group-by...

seancorfield 2018-11-02T03:24:42.004900Z

...but as an exercise in threading, it's common to just thread directly through map/filter without creating small named functions for them.

seancorfield 2018-11-02T03:26:52.007600Z

See Stuart Sierra's Do's and Don'ts blog post about not naming collection functions (but naming the per-element function instead, if necessary).

2018-11-02T03:28:11.009Z

great blog.. thanks for sharing

2018-11-02T03:28:39.009900Z

is this the post you are talking? https://stuartsierra.com/2016/01/09/how-to-name-clojure-functions

seancorfield 2018-11-02T03:28:43.010100Z

In particular, get-pokemon-names is just (->> ... (map :name) ...)

seancorfield 2018-11-02T03:30:16.010500Z

This one https://stuartsierra.com/2015/08/10/clojure-donts-redundant-map

seancorfield 2018-11-02T03:32:57.011300Z

But pretty much everything on his blog is worth reading

👍 2
2018-11-02T03:36:43.011700Z

I will also take a look at the group-by function

seancorfield 2018-11-02T05:46:11.012500Z

(sorry for the somewhat cryptic responses -- I was out having dinner and only had my phone so I couldn't give detailed feedback)

cullan 2018-11-02T15:56:29.013Z

Wow, that really is a nice blog. Thanks for that @seancorfield