code-reviews

2019-01-07T18:20:51.023500Z

@mathpunk a minor thing, the require block makes this line redundant

mathpunk 2019-01-07T18:21:57.023900Z

Ah. Having required cyclotron.case as case, ::case resolves correctly

mathpunk 2019-01-07T18:22:01.024100Z

good to know

2019-01-07T18:23:53.024300Z

using alias for keyword namespaces that don't exist as code namespaces is a nice trick though - it would likely make other namespaces clearer (I assume they were written before you discovered this trick)

mathpunk 2019-01-07T18:26:09.024500Z

I think so. What I was going for is, there were certain ideas that seemed distinct sub-ideas --- like the idea of counting failures --- but that were just data and didn't need functions

2019-01-07T18:28:24.025500Z

here if you used io/resource you could reliably point to something inside the repo (but perhaps it's intentional also that the sample data is not in the repo) https://github.com/mathpunk/cyclotron/blob/master/src/cyclotron/utils.clj#L11

2019-01-07T18:30:06.026200Z

but I also see io/as-file io/resource "reports" elsewhere which doesn't reflect anything visible in the repo