Clojurians Log v2
Clojure programming
Channels
Apps
code-reviews
dharrigan 2019-09-26T05:30:24.021900Z
Thank you both! 🙂
2019-09-26T15:18:33.022200Z
@dawran6 I recommend you this blog post serie on transducers: https://vincent.404.taipei/clojure/build-your-own-transducer-part1/
2019-09-26T15:21:14.022500Z
@dominicm transducers remove all the cost of the laziness and also remove intermediate buffering as well. For a library, it is often desirable.
2019-09-26T15:29:27.022800Z
Appreciate! I came across your blog post just a while ago. Now is a good time to practice it 🙂
1😄 2019-09-26T15:29:35.023Z
I submitted this issue https://github.com/dawran6/emoji/issues/6
2019-09-26T15:30:36.023400Z
Feel free to ask in #code-reviews if you have any question on transducers, remember to tag me.
1🦜 2019-09-26T15:32:07.023800Z
Absolutely!
2019-09-26T15:32:32.024Z
or tag me in the issue if needed (@green-coder)
slipset 2019-09-26T17:24:08.024900Z
@dharrigan I’d consider extracting the checker for :tripData into its own fn.
slipset 2019-09-26T17:24:29.025200Z
possibly also :device.
slipset 2019-09-26T17:25:32.026100Z
@ericnormand talks about this all the time. You’re coupling the what with the where.
slipset 2019-09-26T17:26:17.026500Z
It can also be seen as a violation of https://en.wikipedia.org/wiki/Law_of_Demeter
dharrigan 2019-09-26T18:14:05.026900Z
Thank you! I'll have a read 🙂