Clojurians Log v2
Clojure programming
Channels
Apps
code-reviews
2020-12-14T01:33:35.098200Z
it seems like concatted-array could just be mapcat vs. map
2020-12-14T07:45:01.099100Z
Thx @noisesmith, I'll try mapcat.
2020-12-14T11:43:11.101400Z
Thanks again @noisesmith, great advice!
I just got rid off the concatened-array function, perfect.
2020-12-15T22:44:30.102800Z
We are now entering nitpick territory (this is very nice), but you could use destructuring in your parse-array function arg list to get rid of the first and rest calls and also have clearer naming inside the function
2020-12-15T22:46:00.103Z
(defn parse-array [[key-list & value-lists]]....
2020-12-16T09:56:03.103300Z
Hi @curlyfry! I like to go to niptick territory and I love the destructuring power, so thank you very much for this advice. 🙂 Very elegant now, perfect!
jaihindhreddy 2020-12-17T13:35:10.103800Z
This is a nitpick as well, but I like to keep keys are strings when I get them from somewhere else. You could (group-by #(get % "id")) and avoid the keyword-isation...
2020-12-17T14:12:27.104100Z
@jaihindhreddy Yes, like this version too! Thx!