code-reviews

roelof 2021-01-20T17:09:21.001100Z

hello,

roelof 2021-01-20T17:09:49.001700Z

im busy with my first web project which is not done. I have to add more shelves and images

🎉 1
roelof 2021-01-20T17:10:27.002100Z

but how did I do : https://github.com/RoelofWobben/paintings

2021-01-20T17:16:39.004400Z

@roelof that's a decent start, I'd normally move the hiccup related stuff into a separate ns (since there's so many lines of code related to it, especially with the data literals), and I'd definitely have some style suggestions if I got it as a PR (minor stuff like indentation and simplifying by using different core functions). but overall it's decent (if it gives the output you expect :D)

2021-01-20T17:20:26.005300Z

(also the dot files .calva, .clj-kondo .lsp) are not part of your project and should not be in your repo)

roelof 2021-01-20T18:12:29.006300Z

oke, you may always say what I can more simple

roelof 2021-01-20T18:12:54.006900Z

and move the whole hiccup to a new ns I can do

roelof 2021-01-20T18:13:27.007500Z

and maybe use different methods for the html parts ?

👀 1
roelof 2021-01-20T18:16:29.007700Z

@noisesmith

roelof 2021-01-20T18:23:33.008400Z

or making a PR what to change so I can learn from it