code-reviews

2021-03-17T00:42:24.000700Z

Any thoughts on this bit of core.async code to fetch a bunch of web pages concurrently and wait until they're all finished to return? https://gist.github.com/samcf/427fc7cde338402ffc5c040bf8d692e7

2021-03-17T00:47:06.000800Z

Looks nice to me

2021-03-17T01:22:43.001Z

putting IO (like http requests here) inside go is a bad idea, better to use async/thread then use <! on the chan it returns from another go block

👍 2
2021-03-17T01:23:08.001200Z

the number of go threads are limited and not meant for long running tasks like IO

2021-03-17T01:24:31.001400Z

here core.async isn't doing anything for you - this would be simpler code, and more efficient to boot, using futures or claypoole

2021-03-17T04:41:02.001700Z

thanks, that makes sense, i'll try that out 👍