Clojurians Log v2
Clojure programming
Channels
Apps
contributions-welcome
Do you have some (beginner friendly) tasks on a Clojure project you would like help on? Share your requests for help here!
borkdude 2020-09-21T11:23:14.002700Z
I was going to share https://github.com/borkdude/babashka.curl/issues/26 here, but I see something's already working on that.
borkdude 2020-09-21T11:23:54.003100Z
Another issue: https://github.com/borkdude/sci/issues/422
chucklehead 2020-09-21T18:07:14.007400Z
I took a quick stab at it. One thing I noticed when running the native tests on Windows afterwards is there are 18 failures that all appear to be related to \n vs \r\n.
borkdude 2020-09-21T18:24:13.007600Z
yes, that's another issue.
borkdude 2020-09-21T18:27:20.007800Z
there's in fact an issue at babashka to fix all the tests for windows
borkdude 2020-09-21T18:27:33.008Z
there is a windows-test branch for it. if you are bored, you may PR fixes to that as well.
chucklehead 2020-09-21T18:27:35.008200Z
turns out I lied and didn't run the native tests initially because I had SCI_TEST_ENV="native" instead of SCI_TEST_ENV=native
borkdude 2020-09-21T18:27:40.008400Z
thanks for the script. I hope to try it out soon!
chucklehead 2020-09-21T18:27:54.008600Z
ok, I'll take a look over there
borkdude 2020-09-21T18:28:35.008800Z
borkdude 2020-09-21T18:28:49.009200Z
We are testing native builds in CI
borkdude 2020-09-21T18:29:05.009400Z
and also the JVM build in fact. but only in the windows-tests branch
borkdude 2020-09-21T18:29:43.009600Z
let me try to update it with master
borkdude 2020-09-21T18:32:51.009800Z
ok, updated
borkdude 2020-09-21T20:04:06.010Z
@chuck.cassel Thanks a lot, merged
chucklehead 2020-09-21T20:05:29.010200Z
no problem, I'll see if I can help with the other tests as I have some time