Clojurians Log v2
cryogen
🙏 https://github.com/cryogen-project/cryogen-asciidoc/pull/8
Nice. Looking forward to seeing some improvements in cryogen web.
Once I get back to my website I hope to contribute some features
My focus is on asciidoc as I believe it has more potential (although less tooling suport atm). I also the conventions and structure that https://antora.org/ has around building (documentation) websites from different git repos and modules.
They also have a nice solution for providing an UI
thanks for the PR, just pushed out 0.3.0 version of cryogen-asciidoc with the update 🎉
@yogthos merging the multiple extensions PR broke asciidoc b/c it depends on https://github.com/cryogen-project/cryogen-core/pull/146 being merged into core and then depending on that version > Syntax error (IllegalArgumentException) compiling reify* at (cryogen_asciidoc/core.clj:22:3). > Can't define method not in interfaces: exts Here is a PR to revert it https://github.com/cryogen-project/cryogen-asciidoc/pull/10
@dorab The advice from the Clojure philosophy would be not to change the protocol (a breaking change) but to create a new one or one in a new namespace. Then you could simply add it to core, release it, and the plugins could choose to extend it in their own time
Thanks. I agree. I did think about just adding an exts method to the existing Markup protocol. If I did that, it is my understanding that since the protocol itself has changed, that would still require synchronized updates. Meaning that if someone updated cryogen-core to the version containing the new Markup protocol, they could not continue to use the old implementations of the previous version of the Markup protocol. Is my understanding correct?
Thanks for the merge! Can you re-release 0.3.0 to clojars? or bump the version and release? 🙏
oh yeah I'll push a new version out in a few minutes
ok everything should be up on Clojars
❤️
thanks again for doing the PRs 🙂
• Sorry for the need to simultaneously update the various cryogen repos to handle the multiple-extensions PR. The list of PRs that need to be updated together are:`cryogen-asciidoc` PR number 7
• cryogen-docs PR number 32
• cryogen-markdown PR number 13
• cryogen-flexmark PR number 6 and cryogen-core PR number 146
As @holyjak noted, the dependencies need to be updated after the PRs are applied. I did not want to put the dependency changes into the PRs since I didn't know what the new version numbers would be. I think the current states of the sub-projects of cryogen-project are inconsistent. What is needed is to apply all the PRs in each of the sub-projects mentioned above and then to update all the dependencies.
Please let me know how I can help.