@yogthos Just to be clear, ALL the related PRs need to be applied and then all the dependencies updated. It is not enough to apply just some of them. This is because the name of the protocol method is changed from ext
to exts
. Happy to do this if I have write access to the repos.
I merged all the PRs I think, but check with @carmen about access
@dorab I sent you an invite to the org!
🎉
Does someone want to review the PRs before I merge them? I feel a bit strange merging my own PRs. But happy to do so if needed.
I'm going ahead with merging the PRs.
Should I push out another release for core and asciidoc?
I have applied the changes to all the relevant repos. BUT, I have not yet updated any of the version numbers. I will update the "patchlevel" versions of all the relevant repos and change the dependencies. Then the repos should be ready to be released.
@yogthos, is the current cryogen-core
master branch the same as 0.3.2
? Asking because the last tag on the repo is 0.3.1
but the README says 0.3.2.
I downloaded and looked at 0.3.2 and it looks like it matches master.
I updated the master
branch of the following repos:
• cryogen-asciidoc
to 0.3.2
cryogen-markdown
to 0.1.13
cryogen-flexmark
to 0.1.4
cryogen-docs
to 0.1.1
I updated the project.clj
in each of these repos and created a tagged release in each repo.
I'll leave the publishing of each of these repos to clojars to @yogthos.
I'll note that the circleci build of cryogen-docs
failed . Presumably because the correct versions of the dependencies are not yet on clojars. Other circleci jobs might fail too, for the same reason.
After publishing to clojars, it might be good to run the tests in cryogen-core
with all the latest versions.
Going to bed now. Will check back here tomorrow morning.
One other thing ... I did not make any changes to cryogen-core
since 0.3.2 seemed to have all the necessary changes.
fantastic, just released all the updated libraries
and @carmen can take a look at the docs
oh it looks like the docs wasn't building because I haven't pushed the new libraries to clojars yet