Clojurians Log v2

Carmen and Dmitri gave their LGTM here https://clojurians.zulipchat.com/#narrow/stream/180378-slack-archive/topic/cryogen/near/215103821, scroll up few posts and back to follow the discussion where Carmen had the same proposal as you about a flag but retracted it eventually after I explained the opt-in .

Thanks to the pointer to the previous discussions. I had not realized it was opt-in. I see that now. Thanks for fixing the conflicts. Github says there are conflicts on the associated PR220 on the cryogen repo. Once you resolve that conflict, I can test out both PRs and merge them. One note - this PR#149 changes the version in project.clj. Perhaps it should be changed to 0.4.1-SNAPSHOT? Or perhaps this PR should not change the version at all, and the version should be changed only when a coordinated set of changes are made?

Thanks, conflict fixed

Regarding the version: I think it is good practice to change it since this is not part of 0.4.0 and being -SNAPSHOT it is clear it is not made for release. When we decide to make a release, then we change it to whatever we see appropriate and release. But if you prefer, I can drop the version change. Ideally, IMHO, the version would already have been "NEXT" but maven does not support that 🙂

Okay. Thanks. I have to step out right now, but will review and merge later. The version issue is another thing that could be discussed in #cryogen .

Right. Perhaps we should write down guidelines for when, how to bump the version?