Clojurians Log v2

I'm getting an inconsistent result using the sum aggregate function on dev-local. If I include only the sum function, the result is much less than it should be. If I add the count function to the same query, the result of the sum function is then correct. Here's the query with only the sum function. There are multiple batch items per batch and I need the total weight of all batch items.

[:find ?e ?formula-name ?doses ?date (sum ?weight) 
         :keys e formula-name doses date total-weight 
         :in $ ?e
         :where [?e :batch/formula ?fe]
         [?fe :formula/name ?formula-name]
         [?e :batch/doses ?doses]
         [?e :batch/date ?date]
         [?bi :batch-item/batch ?e]
         [?bi :batch-item/weight ?weight]]

Here's the query with both the sum and count aggregate functions:

[:find ?e ?formula-name ?doses ?date (sum ?weight) (count ?bi)
         :keys e formula-name doses date total-weight count
         :in $ ?e
         :where [?e :batch/formula ?fe]
         [?fe :formula/name ?formula-name]
         [?e :batch/doses ?doses]
         [?e :batch/date ?date]
         [?bi :batch-item/batch ?e]
         [?bi :batch-item/weight ?weight]]

https://docs.datomic.com/cloud/query/query-data-reference.html#with

[:find ?e ?formula-name ?doses ?date (sum ?weight)
         :keys e formula-name doses date total-weight
         :with ?bi
         :in $ ?e
         :where [?e :batch/formula ?fe]
         [?fe :formula/name ?formula-name]
         [?e :batch/doses ?doses]
         [?e :batch/date ?date]
         [?bi :batch-item/batch ?e]
         [?bi :batch-item/weight ?weight]]

What does that return?

Reading now .... so duplicates are being excluded from the sum?

It's correct now!

That's subtle. Thanks @lanejo01

Does the concept of a set vs a bag make sense to you from the docs?

I understood immediately that duplicates might be excluded from (sum ...) when I saw the example, but that's not what one would expect from a sum function.

2 + 2 = 2 ???

So I think it might be good to point this out in the sum section of the documentation (if it isn't there already)

It's not related to the sum aggregate though, it's related to whether or not you want a bag vs a set of the ?bi lvar.

It's a more general concept.

;; query
[:find (sum ?count) 
 :with ?medium
 :where [?medium :medium/trackCount ?count]]

I understand it doesn't only apply to the sum aggregate. I'm only saying that if it has a non-obvious impact on a specific aggregate function, it might be helpful for beginners like me to point that out.

Interesting. I hadn't learned enough about Datomic to realize it specifically deals in sets by default instead of bags...

It is still quite vague to me when a query would return a set.

I guess it has to be kept always in mind, because as the example in the documentation on With Clauses shows, it isn't only an issue with some aggregate functions.

@lanejo01 Here's a specific suggestion for the docs that might help to make this more clear for beginners. In the subsection on sum where it says "The following query uses sum to find the total number of tracks on all media in the database." You might change that to something like "The following query uses sum to find the total number of tracks on all media in the database. Note carefully the use of the with-clause in the query so that all trackCounts are summed. If the with-clause is excluded, only unique trackCounts will be summed."