depstar

Discussion around https://github.com/seancorfield/depstar
dharrigan 2020-12-24T04:49:39.291600Z

Thank you @seancorfield will test this morning 🙂

1
dharrigan 2020-12-24T05:18:21.292300Z

Yup works - but first had to align the scm tag to the same as the version, then update

dharrigan 2020-12-24T05:18:45.292500Z

works grand now 🙂

seancorfield 2020-12-24T05:20:06.293300Z

Cool. Yeah, if they're out of sync, it can't do much to sync them back up.

seancorfield 2020-12-24T05:21:21.295600Z

When I first implemented :sync-pom true, if you specified :version and had an existing pom.xml, the call into t.d.a would update the <version> field and then my own sync'ing code couldn't match <tag> match (because the version field had already been changed).

seancorfield 2020-12-24T05:21:57.296900Z

So now, :version (and :group-id and :artifact-id) are only passed to t.d.a's pom-sync'ing code when no pom.xml exists.

seancorfield 2020-12-24T05:22:10.297400Z

(and in that case, there's no <tag>)

dharrigan 2020-12-24T05:22:43.297600Z

YOu know, I did the obvious thing when I first tried it out yesterday, I did sync-pom without reading the documentation (and not having a pom.xml). It threw a NPE to the console. After reading the documentation, I added in the version, groupid etc., and it worked. However, do you think it might be worthwhile to catch that NPE (for dummies like me) and guide the user to add in a groupid, artifactid and version?

seancorfield 2020-12-24T05:23:51.298400Z

Probably a good idea. I could even trap it before calling into t.d.a and give a better message altogether.

dharrigan 2020-12-24T05:24:39.299100Z

That would be helpful 🙂 Something to ponder.

seancorfield 2020-12-24T05:25:42.299300Z

https://github.com/seancorfield/depstar/issues/56

dharrigan 2020-12-24T05:25:57.299600Z

noice

seancorfield 2020-12-24T05:28:26.301100Z

I'll need to clean up the option verification stuff before I can implement that. The code needs a serious refactor. It's at the limit of what I can maintain in the main function right now.

dharrigan 2020-12-24T05:29:39.301500Z

you have a lot on your plate! this, honeysql, next.jdbc....

seancorfield 2020-12-24T05:30:56.302400Z

The sponsorship really helps... it means I can really justify working on OSS for whole days at a time instead of a few hours here and there.

seancorfield 2020-12-24T05:31:36.302900Z

Jay is happy for me to be doing "semi-work" instead of watching TV 🙂

dharrigan 2020-12-24T05:32:14.304300Z

🙂 Let me know if I can be of any assistance. Happy to spend a few hours testing things out if you need someone.

seancorfield 2020-12-24T05:32:27.304600Z

("work-work" is my day job, "play-work" is unpaid stuff I do on the computer, "semi-work" is the new term for "unpaid stuff I do" that I'm now actually getting paid for)

seancorfield 2020-12-24T05:33:34.305600Z

Thanks. You're a very proactive user of several of my projects and that is very valuable on its own because you actually provide feedback (both positive and negative) on how stuff actually works.

dharrigan 2020-12-24T05:33:45.305800Z

you're most welcome! 🙂

seancorfield 2020-12-24T05:35:16.306200Z

The next "big" piece of work is to break my current logjam on HoneySQL...