Devcards aims to provide a visual REPL experience for ClojureScript
anmonteiro 2017-09-28T19:59:15.000013Z

@bhauman I see you’re trying to push Sablono to support React 16

anmonteiro 2017-09-28T19:59:24.000362Z

but Devcards is still not fully React 16 compat

bhauman 2017-09-28T19:59:37.000366Z

the next release is?

anmonteiro 2017-09-28T19:59:40.000227Z

specifically devcards.system/cljs-logo uses React.DOM

anmonteiro 2017-09-28T19:59:47.000321Z

and that was removed

anmonteiro 2017-09-28T19:59:54.000684Z

you may want to use js/React.createElement

anmonteiro 2017-09-28T20:00:12.000188Z

I just built a Devcards Snapshot from master

anmonteiro 2017-09-28T20:00:14.000563Z

and it’s choking on that

bhauman 2017-09-28T20:00:24.000642Z

Oh thanks!!

anmonteiro 2017-09-28T20:00:26.000571Z


anmonteiro 2017-09-28T20:00:34.000324Z

I’ll report anything else I find

bhauman 2017-09-28T20:00:44.000442Z

I don't know how that made it this far

anmonteiro 2017-09-28T20:01:15.000538Z

actually let me fix that locally to see if that makes it work

anmonteiro 2017-09-28T20:06:05.000622Z


anmonteiro 2017-09-28T20:06:08.000433Z

this made it work for me

anmonteiro 2017-09-28T20:06:18.000610Z

(also backwards compatible)

bhauman 2017-09-28T20:07:10.000383Z


anmonteiro 2017-09-28T20:07:15.000208Z


anmonteiro 2017-09-28T20:08:50.000297Z

@bhauman can you deploy a snapshot with sablono 0.8.1-SNAPSHOT?

bhauman 2017-09-28T20:08:59.000091Z


anmonteiro 2017-09-28T20:09:02.000304Z


anmonteiro 2017-09-28T20:09:18.000467Z

that’s working for me with React 16

anmonteiro 2017-09-28T20:09:36.000218Z

even though @r0man didn’t release 0.8.1 yet, there’s the snapshot which works

bhauman 2017-09-28T20:10:19.000001Z

it will be about 30 minutes before I cut a release

anmonteiro 2017-09-28T20:10:38.000406Z

no rush

anmonteiro 2017-09-28T20:11:50.000281Z

@bhauman ooops another PR incoming, I’m sloppy and found more cases of React.DOM

anmonteiro 2017-09-28T20:12:40.000057Z

let me grep the whole project

anmonteiro 2017-09-28T20:12:46.000188Z

make sure I don’t mess this one up

anmonteiro 2017-09-28T20:18:55.000572Z

@bhauman OK this is the last one, makes Devcards work with React 16 + a rather comprehensive collection of devcards

anmonteiro 2017-09-28T20:19:07.000556Z

sorry for the churn

bhauman 2017-09-28T21:18:32.000302Z

@anmonteiro deployed 0.2.4-SNAPSHOT

anmonteiro 2017-09-28T21:18:41.000047Z


bhauman 2017-09-28T21:18:43.000290Z

Thanks for the help!