Clojurians Log v2

I think there is no need to support switchable impls

the problem is that http-kit is used in other parts I think, so I don’t want to have jetty somewhere and http-kit elsewhere

I’d like to pick just one lib, also depends on how the code will look, I will be probably the one who will be stuck maintaining it for foreseeable future

let me think about it, will tell you tomorrow

it is too late here, don’t want to promise anything at this point

all good, thanks 😄 @darwin

@darwin: Re cljs-devtools 0.7.0 I’ve tested with boot 2.6.0, jupl/boot-cljs-devtools 0.1.0 and Dirac 0.6.0 - all working fine :thumbsup: Just for boot users we need @jupl to do https://github.com/jupl/boot-cljs-devtools/issues/1 so we can get back :sanity-hints 😉

@darwin: thanks for the blistering pace of development! All these features are making it far nicer to work in ClojureScript.

I’ve been neck deep in JS work the past few weeks. My apologies for not having a chance to get involved. PRs are welcome at least.

@jupl all good I know how that is 😄 I’ll work on a PR for that this evening, are you able to merge the PRs from arichiardi ? Some of that work is pretty handy.

@superstructor I did. I asked that the commits get squashed. If I have time later in the week or the weekend I’ll add it manually.

right sorry hopefully @richiardiandrea has time to squash soon 🙂

Will do! ;)

Btw does GitHub have merge with squash now? Just curious

@richiardiandrea: I verified your install-order branch fixes being able to breakpoint on app init functions (i.e. devtools etc is correctly installed before other init fns)

Great I wanted to check if that patch worked fine thanks for doing that

So I guess that one can be merged @jupl

@richiardiandrea: Awesome! I’ll need to jump off so I’ll try to take a look tomorrow

Thanks!

@superstructor: I’m using http-kit only in two places dirac.lib.weasel-server and dirac.lib.ws-server, I briefly looked at the ring wrappers around jetty and those apis look very similar to http-kit, so in theory it should not be hard to replace, feel free to go for it, I’m fine ditching http-kit for jetty. You may convert only dirac.lib.ws-server and I will then consider converting weasel-server as well.

@jupl: do you want me to squash all the commits, even the readme/deps changes?

@darwin: great, thanks 🙂 will get back to you when I have a pull request ready.