Hi, after updating to Chrome Canary 66.0.3335.0 I have strange behavior. When I start Dirac it starts with Dirac 1.2.26 <-> http:/localhost:300/ in the title, but after 3 second it changes to Dirac 1.2.26 <-> ? and in Console I see:
Dirac requires runtime support from your app.
Please install Dirac Runtime into your app and enable the :repl feature.
[:dirac.implant.eval/install-check-timeout]
Is it only me? Or does somebody see the same?@darwin should I open an issue?
try to refresh your app’s browser window once again when dirac is up
I noticed this when preparing .26 release, not sure what is causing it
it happened occasionally to me
refresh does not help
do you see any js errors in the Dirac’s window own devtools?
Hmm, when I press ctrl + shit + I when I have Dirac window open, it only opens the Dirac window again, what I am doing wrong? Sorry
I’m going to try to repro this with dirac-sample project
Thank you very much, I will try to get Dirac Dev Tools open in the meantime 🙂
@darwin uploaded a file: https://clojurians.slack.com/files/U08E3BBST/F91BG9A03/-.clj
probably this commit broke official devtools: https://chromium.googlesource.com/chromium/src/+/b37cae9024754d1cad99be6f3fd1628e71d410b4
or maybe better to say, I need to update Dirac with updated sources
to work-around this, you should install 3333.2 version of Chromium for the time being, the link is here https://github.com/binaryage/dirac/releases/tag/v1.2.26
Thank you very much as always! I really appreciate all your work and attention!
I should probably roll updated dirac release ASAP
‘btw. did you manage to open dirac devtools’ own devtools? 🙂
It should really work and you should see the same js error as pasted above 🙂
btw. automated tests against latest chromium failed with the same problem: https://travis-ci.org/binaryage/dirac/builds/335463548
Well I did after all from settings pane, clicking on devtools/front_end/inspector.html
link 🙂
The first thing is same as you sent above.
don’t you have a global shortcut set to open dirac devtools overriding the standard one?
Well you know, with me everything is possible.
I don’t think it would allow it, but check this out: https://github.com/binaryage/dirac/blob/master/docs/faq.md#how-do-i-focus-dirac-repl-prompt-via-a-keyboard-shortcut
I was using Chrome Canary, with your recommended version of Chromium everything works, even Dirac DevTools. Thank you very much
this was just a bad luck, dirac’s devtools sources started to be incompatible with latest chrome due to some breaking changes in chrome’s devtools protocol, we cannot realistically avoid this
this would at least properly report incompatibility: https://bugs.chromium.org/p/chromium/issues/detail?id=538300#c20
but it would be extra work for chrome devs
Yea, I don't blame anyone or anything. This is how it is, when you are living on the edge.
Still it is more than worthy for me
Dirac is god send for cljs frontend dev
@darwin Would it be possible to [optionally] make Leiningen or something similar to always download automatically whatever Chromium version is the best for Dirac?
@p-himik that would be possible, but nobody probably put an effort into making something like this automated 🙂
it is confusing, I agree, but this thing happens very rarely and usually I’m faster with updated Dirac release than people notice it on their machines
And is it simpler to just check for Chromium version and alert the user when it's not the ideal one, while maybe also giving a link to the ideal one?
@p-himik I would be a range check, and I don’t have the information which versions are compatible
“DevTools frontend can adapt dynamically and does not fatally break when used with a slightly different Chrome version”
if this is an concern, I would recommend this: https://github.com/binaryage/dirac/blob/master/docs/faq.md#how-do-i-stick-to-a-particular-dirac-version
simply stick with particular dirac and chromium versions which are tested to work well
and update only manually
both of them in lock-step
Oh, no, I don't mean the "set of versions that are guaranteed to work", I mean just something like that line in the release you pointed out: "Should work best with Chrome ~66.0.3333.2." The thing is, there's no such thing as Chrome Canary on Linux. And nowhere in the Dirac documentation it says that Chromium is supported as well, so a clearly visible link (just like the one you show when Dirac versions mismatch) would probably ease things for Linux users.
(but now I know that Chromium is supported as well, which is good 🙂 )
well, I should probably report internal dirac error on all console errors in Dirac’s window, not sure why it wasn’t triggered this time
and in that message I could mention compatible Chromium version
or where would you put that “clearly visible link”
?
Somewhere under that green plaque - like the message about Dirac versions mismatch.
but that should not be a warning, that would be displayed all the time I guess, because you will always have slightly different Chrome version than Dirac’s devtools snapshot
but I see, I could add the information there
Yeah, not a warning - just something that one should check first whenever something doesn't work as it's supposed to. Thanks! 🙂