duct

2019-12-20T00:03:40.002100Z

Good point. Removed.

kwrooijen 2019-12-20T08:21:19.004100Z

@weavejester If you have time, could you take a look at these? https://github.com/duct-framework/duct/pull/95 https://github.com/duct-framework/duct/pull/105 It would probably help new people start with Duct 🙂 Also a small README fix: https://github.com/duct-framework/migrator.ragtime/pull/11 Sorry to be linking PRs to you, it’s probably annoying. One of them has been open for quite a while though.

kwrooijen 2019-12-20T08:26:02.005100Z

Also; I added a link to the Duct guide here: https://github.com/duct-framework/duct/wiki I don’t think the guide is referenced anywhere else. But it’s a good source to read.

2019-12-20T14:27:56.006700Z

@kevin.van.rooijen Linking PRs is fine. I have a lot of repos, so sometimes I can’t deal with everything immediately, and old PRs get lost in the depths of my todo list. I’ve added some comments to the PRs. When they’re resolved, I’ll merge.

kwrooijen 2019-12-20T14:34:30.007300Z

@weavejester Fixed the two comments, I’ll do my best to follow the guidelines from now on. Is the 3rd PR fine?

2019-12-20T14:36:47.007700Z

@kevin.van.rooijen All merged.

kwrooijen 2019-12-20T14:37:41.008400Z

Great! Thanks for taking the time to look at them. There’s also a bug in the Duct template for the test profile. I’ll see if I can push a fix tonight / tomorrow.

2019-12-20T14:38:09.008600Z

Thanks

kwrooijen 2019-12-20T14:40:46.008900Z

I think this can be officially closed? https://github.com/duct-framework/core/issues/12

2019-12-20T14:42:05.009200Z

Closed.

kwrooijen 2019-12-20T14:42:20.009400Z

👍