@borkdude Eastwood might not be so great as I was claiming at finding everything possible. From skimming the code, it is looking for all top level forms inside of deftest
or testing
macro invocations, and warning if they are constant expressions (e.g. a string or []
), or an invocation of a function or macro that configuration data lookup says is a predicate or pure function.
Probably best to try a quick test case to see if Eastwood actually does catch TDEPS case discussed recently, or not.
ah, great, that's kind of what's clj-kondo is doing as well, except for checking inside testing
Yeah, hopefully also doing checking inside of testing
forms should be a small change to clj-kondo.
speaking of eastwood. it might be worth checking out the LSP protocol for editor integration. I'm using that for clj-kondo on Windows in VSCode now. it doesn't require a binary, but just runs as a JVM in the background
extending this to clojure.test/testing is fairly trivial
but there are so many small things to do, that it might take a while unless someone wants to do a PR
sure, no worries. Maybe a Github issue marked as beginner or something like that, if you do that kind of thing.
I have tried that, but it didn't really help attracting more contributions. It's usually driven more by how bad people want a feature themselves than opportunities to contribute in general (and that's fine).
I have a project board indicating priorities: https://github.com/borkdude/clj-kondo/projects/1
and I just bumped the testing thing