Discussion about all editors used for Clojure/ClojureScript
juhoteperi 2016-02-25T13:16:25.000038Z

@dominicm: re: virtualenv with Neovim: https://github.com/neovim/neovim/issues/3396

juhoteperi 2016-02-25T13:27:27.000040Z

@dominicm: I'll do PR soon with fixes and improvements

dominicm 2016-02-25T13:28:42.000041Z

@juhoteperi: I figured something like that would be possible. I think npm's model works best. Thanks! I'm using it in a project today, so I'll get a few things too I hope. My python-fu isn't as good as it used to be. I need to come up with safer key lookup systems. But it's just so many if/else's that I didn't want to worry about.

dominicm 2016-02-25T13:28:59.000042Z

Majority of it works quite nicely though, I'm rather happy with it.

juhoteperi 2016-02-25T13:29:29.000043Z

@dominicm: I'll fix key lookups and add support for additional data for candidates (arglist, type etc.)

dominicm 2016-02-25T13:31:15.000044Z

@juhoteperi: Awesome, thank you! I hadn't even started thinking about arglist/type stuff. I look forward to seeing that.

dominicm 2016-02-25T15:40:36.000045Z

@juhoteperi: I should apologize for some of my bad code in there, I was getting really confused about things that were breaking, and then magically fixed when I changed to doing weird things (like that r variable..). I'm not sure at all what did fix those things in the end. 😛

dominicm 2016-02-25T15:41:33.000046Z

This is what I call "I have a train coming in 5 minutes, do whatever gets the code to run" debugging.

juhoteperi 2016-02-25T15:43:11.000047Z

@dominicm: I think source shouldn't set min_pattern_length as it looks like that will override user auto_completion_start_length (or could be bug in deoplete)

juhoteperi 2016-02-25T15:43:43.000048Z

but I think other sources don't set it?

juhoteperi 2016-02-25T15:45:54.000049Z

fixed in the PR :simple_smile:

dominicm 2016-02-25T15:46:14.000050Z

@juhoteperi: No, most don't.. ah, that was it, to do with the regex value whilst I was debugging. Awesome, thank you.

dominicm 2016-02-25T15:51:10.000051Z

I've loaded your patches into local, I'll give them a whizz, then accept :simple_smile:

juhoteperi 2016-02-25T15:54:57.000052Z

Looks like fireplace could just embed this deoplete source and it would get used when deoplete is available

juhoteperi 2016-02-25T15:55:13.000053Z

clang_complete does that, and it should also work with regular Vim

dominicm 2016-02-25T16:01:45.000054Z

It's a possibility. I have no idea if that aligns with the pope's view of fireplace though. We can bring it to his attention & see what he thinks though.

dominicm 2016-02-25T16:34:12.000055Z

@juhoteperi: No idea if you're using your changes, but they enable the docstring coming up whilst you're typing. That's awesome, I didn't think we'd be able to achieve feature parity with the omnicompletion (I hadn't checked out deoplete's features yet). One minor annoyance; keywords put 0 into the scratch buffer. But I'll take a look at the best solution for that a little later.

dominicm 2016-02-25T16:34:21.000056Z

This is super cool.

juhoteperi 2016-02-25T16:35:22.000057Z

I have docstring preview disabled (I don't like the preview window - not sure if Neovim has some alternatives)

juhoteperi 2016-02-25T16:35:28.000058Z

What is scratch buffer?

dominicm 2016-02-25T16:38:12.000059Z

I don't like it much either. But I'm glad that we have it, just for the sake of matching. scratch buffer = where docstring preview shows.

juhoteperi 2016-02-25T16:41:31.000060Z

Aha. Fixed it, val.get("doc") returned None. Using empty string as default works.

dominicm 2016-02-25T16:42:38.000061Z

Oh, an empty string works? Neat 😛 I just merged your PR. Sorry 😛

juhoteperi 2016-02-25T16:42:55.000062Z

I had already pushed the fix so it was merged

dominicm 2016-02-25T16:46:21.000063Z

Oh, well timed!