Clojurians Log v2

@juhoteperi: That bug you found in clj-async-omni seems to be an underlying bug in the nrepl-python-client

Hmm? Or just how nrepl-python-client works

Are you refering to the bug I fixed or some other bug?

With the original bdecode:

❯ python notadrill.py
>>  {'symbol': 'a.s.', 'ns': 'myns', 'op': 'complete'}
<< {}
<< session
<< c36ce69a-0a16-4323-af89-6d972dd6902c
<< status
<< ['done']
<< None

>>  {'op': 'complete', 'symbol': 'a.s.', 'ns': 'teamhero.microformat'}
<< {'completions': [], 'status': ['done'], 'session': '92e73f6a-52b2-4c22-a9da-a3b274114a3d'}

So looks like nrepl.bencode is calling connection read after it has already finished reading the message or something?

nrepl.bdecode seems to get confused and end the map prematurely (resulting in the {} on line 3)

That leaves additional data on the buffer, so it reads again.

Ah! and then we get None, because the real end of the map is left in the buffer, and nrepl.bdecode returns None if it doesn't understand

hmm, fireplace has working implementation written in python?

perhaps we could just copy nrepl_fireplace.py into clj-async-omni and modify it for our purposes

would also remove need for submodule

Yeah, that's my thoughts as well. Licensing and copyright slightly concerns me though, so I might have to dig in to that a little.

Would be easiest if you select to use Vim license for async-clj-omni, and then just add a comment to the file

But even if you select another license for the project, you can keep the copied file under Vim license

ah, misread your suggestion of using all of nrepl_fireplace.py.

There's a problem with that, nrepl_python_client provides a watchable connection, which is pretty key to being able to cache connections. So it would need implementing on top of nrepl_fireplace.

Hmm, true, fireplace implements that it Vimscript side

Does fireplace even use watchable connections? I thought the blocking nature of it, meant it could just keep reading for the duration of the evaluation.

Some part of fireplace code is async, only the Vim side blocks

Interesting.

Maybe I can figure out the bdecode bug, and fix it, using nrepl_fireplace as an example to draw inspiration from

Gotcha, it's a truthy check failure.

PR is opened.