Discussion about all editors used for Clojure/ClojureScript
andresrgz 2018-05-13T09:20:04.000054Z

Hello @pez and @pedrorgirardi! I hope you guys are doing fine and having a great weekend. I just added a feature to Calva, please check it out and tell me what you think. πŸ™‚ https://github.com/BetterThanTomorrow/calva/pull/39

pez 2018-05-13T09:23:58.000012Z

@andres.rodriguezhn: Many thanks for helping out! I’m having a look.

andresrgz 2018-05-13T09:26:09.000042Z

No problem!

pez 2018-05-13T09:36:31.000044Z

Looks good and things still work. πŸ˜ƒ. I pulled it in. Again, thanks! FYI we are probably going to continue/restart the porting to ClojureScript in a separate branch and mainly do bug fixes on the current hybrid Javascript/Clojurescript version, but this change makes sense to add anyway, since it broadens the application of Calva (and will rebase cleanly onto the β€œrewrite” branch).

andresrgz 2018-05-13T09:38:12.000027Z

Cool! On what OS did you try it?

andresrgz 2018-05-13T09:38:59.000060Z

Thanks for accepting this feature, I'm a college student and this is my first pull request for an open source project! πŸ™‚

pez 2018-05-13T09:39:48.000079Z

Mac. But from the look of things the defaults make things that used to work, keep working w/o the users having to change anything, regardless of OS.

andresrgz 2018-05-13T09:40:14.000086Z

Nice, that's what I was aiming for haha.

pez 2018-05-13T09:42:09.000008Z

Cool that Calva got your first PR ever! πŸ˜ƒ

pedrorgirardi 2018-05-13T11:02:29.000107Z

Thank you @andres.rodriguezhn !! πŸ˜ƒπŸ˜ƒπŸ˜ƒ