@bhauman thank you! Just upgraded my React Native project, seems to work well
@bhauman I created this one-line pull request for react-native-figwheel-bridge https://github.com/bhauman/react-native-figwheel-bridge/pull/9
@bhauman Hi! I just tested
:bundle . Seems to be using the pre-webpack file, getting this:
there is a pretty hard design problem for us here
I relied on having the :output-to being the file to load for auto-testing, but now we dont’ know the name of the final output file because its generated by webpack
so auto-testing, and the default index page that hosts the repl, no longer work
I’d love some feedback from folks on an approach to fixing this
I think adding yet another configuration key like
:final-output-file seems like it would work, but it would be nice if there was a better idea
@bhauman cljs-test-runner with doo has the same problem. I forked it to do something similar to your
:final-output-file. Don’t have any better ideas right now
extra-mains doesn’t work right now, but it will once I allow the bundle-cmd
You couldn’t possibly know where the file is, unless you parse webpack.config.js or if there’s a convention on where the file final file is. Is file naming conventions an option?
so if bundle is target, look for this specific file, if it isn’t there then fall back to more verbose config?
yeah its tough, and we’ll probably end up with this
:final-output-file, a convention for the final file is interesting
@bhauman Don’t know what’s out there, our configs tend to be relatively homogenous with files mostly ending up in the same place with the same name.
well I can get extra-mains working for now at least
extra-mains doesn’t need that because you make the html host page
so you know where the output-file is
its only when we need to include it automatically
actually thats not true!
@ingesol I’m wrong about that, extra-mains needs the output-file as well
but folks can make their own host pages for auto-testing and extra-mains
So if you wanted auto-testing to work right now you should be bale to do that
I’m guessing most people prefer the generated pages for things like testing and devcards?
Right, by just making my own copy of host page?
I think so
nice, I can test that right awy
oh but the bundle-cmd is wrong!
I tested latest bundle figwheel on our relatively large project, seems to work fine, by the way
I mean that is great!!
dang it, the bundle-cmd is going to be wrong for auto-testing
its going to use you webpack.config and write over your
I’m confused. Isn’t the webpack-processed main.js the same file (almost) that was our final target file before target=bundle was introduced?
yes pretty similar, but with extra-mains and auto-testing the bundle-cmd is going to be called at the end of compile
In other words autotesting needs to be bundled, but doen’t currently know how to do that
so it will fall back the current :bundle-cmd which is wrong
anyway I’m working on it now
:extra-mains right now and its not simple
So worst case a separate webpack config file for testing?
Using :bundle, I'm not seeing code reloading work. With errors like
Error: Namespace "com.commsor.membership_management.ui.members" already declared. (this is the ns I changed) ending with the .main ns.
So, code reloading takes place. But it doesn't reload any code. If I reload the tab, the code is updated.