raspasov 2020-05-15T08:21:37.247400Z

@bhauman thank you! Just upgraded my React Native project, seems to work well

raspasov 2020-05-15T08:37:22.248500Z

@bhauman I created this one-line pull request for react-native-figwheel-bridge

ingesol 2020-05-15T12:46:35.250600Z

@bhauman Hi! I just tested :auto-testing with :bundle . Seems to be using the pre-webpack file, getting this: <script type="text/javascript">import {npmDeps} from "./npm_deps.js"; in the browser. Is it broken/not fixed yet, or is there something I should do to fix my config?

bhauman 2020-05-15T13:52:28.251100Z

@ingesol yeah autotest doesn’t work

bhauman 2020-05-15T13:56:12.251900Z

there is a pretty hard design problem for us here

bhauman 2020-05-15T13:57:06.253Z

I relied on having the :output-to being the file to load for auto-testing, but now we dont’ know the name of the final output file because its generated by webpack

bhauman 2020-05-15T13:57:37.253600Z

so auto-testing, and the default index page that hosts the repl, no longer work

bhauman 2020-05-15T13:58:09.254200Z

I’d love some feedback from folks on an approach to fixing this

bhauman 2020-05-15T13:59:29.255500Z

I think adding yet another configuration key like :final-output-file seems like it would work, but it would be nice if there was a better idea

ingesol 2020-05-15T14:00:55.256500Z

@bhauman cljs-test-runner with doo has the same problem. I forked it to do something similar to your :final-output-file. Don’t have any better ideas right now

bhauman 2020-05-15T14:02:02.257600Z

extra-mains doesn’t work right now, but it will once I allow the bundle-cmd

bhauman 2020-05-15T14:03:02.258400Z

@ingesol well we might end up with final-output-file

ingesol 2020-05-15T14:05:06.259800Z

You couldn’t possibly know where the file is, unless you parse webpack.config.js or if there’s a convention on where the file final file is. Is file naming conventions an option?

ingesol 2020-05-15T14:05:50.260600Z

so if bundle is target, look for this specific file, if it isn’t there then fall back to more verbose config?

bhauman 2020-05-15T14:11:13.263800Z

yeah its tough, and we’ll probably end up with this :final-output-file, a convention for the final file is interesting

ingesol 2020-05-15T14:13:59.264900Z

@bhauman Don’t know what’s out there, our configs tend to be relatively homogenous with files mostly ending up in the same place with the same name.

bhauman 2020-05-15T14:16:33.265300Z

well I can get extra-mains working for now at least

ingesol 2020-05-15T14:18:43.265800Z

@bhauman with convention, you mean, or with final-output-file?

bhauman 2020-05-15T14:19:16.266300Z

extra-mains doesn’t need that because you make the html host page

bhauman 2020-05-15T14:19:30.266600Z

so you know where the output-file is

ingesol 2020-05-15T14:19:42.267100Z


bhauman 2020-05-15T14:19:47.267300Z

its only when we need to include it automatically

bhauman 2020-05-15T14:21:50.268200Z

actually thats not true!

bhauman 2020-05-15T14:22:09.268700Z

@ingesol I’m wrong about that, extra-mains needs the output-file as well

bhauman 2020-05-15T14:22:53.269300Z

but folks can make their own host pages for auto-testing and extra-mains

bhauman 2020-05-15T14:23:27.270100Z

So if you wanted auto-testing to work right now you should be bale to do that

ingesol 2020-05-15T14:23:31.270400Z

I’m guessing most people prefer the generated pages for things like testing and devcards?

bhauman 2020-05-15T14:23:40.270800Z


ingesol 2020-05-15T14:23:41.270900Z

Right, by just making my own copy of host page?

bhauman 2020-05-15T14:23:44.271100Z

I think so

ingesol 2020-05-15T14:23:55.271500Z

nice, I can test that right awy

bhauman 2020-05-15T14:24:16.272400Z

oh but the bundle-cmd is wrong!

ingesol 2020-05-15T14:24:16.272500Z

I tested latest bundle figwheel on our relatively large project, seems to work fine, by the way

bhauman 2020-05-15T14:24:21.272700Z

dang it

bhauman 2020-05-15T14:24:40.273Z

I mean that is great!!

bhauman 2020-05-15T14:25:01.273500Z

dang it, the bundle-cmd is going to be wrong for auto-testing

bhauman 2020-05-15T14:25:31.274100Z

its going to use you webpack.config and write over your

bhauman 2020-05-15T14:25:49.274600Z

dev build

ingesol 2020-05-15T14:26:37.275500Z

I’m confused. Isn’t the webpack-processed main.js the same file (almost) that was our final target file before target=bundle was introduced?

bhauman 2020-05-15T14:28:23.276600Z

yes pretty similar, but with extra-mains and auto-testing the bundle-cmd is going to be called at the end of compile

bhauman 2020-05-15T14:57:49.278200Z

In other words autotesting needs to be bundled, but doen’t currently know how to do that

bhauman 2020-05-15T14:58:11.278700Z

so it will fall back the current :bundle-cmd which is wrong

bhauman 2020-05-15T16:02:02.279300Z

anyway I’m working on it now :extra-mains right now and its not simple

ingesol 2020-05-15T20:29:43.282500Z

So worst case a separate webpack config file for testing?

dominicm 2020-05-15T22:58:31.282600Z

Using :bundle, I'm not seeing code reloading work. With errors like Error: Namespace "com.commsor.membership_management.ui.members" already declared. (this is the ns I changed) ending with the .main ns.

dominicm 2020-05-15T22:58:55.282700Z

So, code reloading takes place. But it doesn't reload any code. If I reload the tab, the code is updated.