figwheel-main

figwheel-main http://figwheel.org
2020-06-16T17:51:27.286900Z

Anyone else using re-frame-10x with the new webpack? If you use :exclusions [cljsjs/react-highlight] so that :npm-deps true works it doesn’t take that well… It seems to work without using the exclusions, but I’m not 100% certain that’s a good thing…

bhauman 2020-06-16T18:10:28.287500Z

@folcon I just wrote this up

bhauman 2020-06-16T18:13:59.289400Z

I added a :clean-outputs Figwheel option and a --clean CLI opt to the 0.2.9 release of figwheel.main

bhauman 2020-06-16T18:14:14.289800Z

this is more than likely what you are running into again

bhauman 2020-06-16T18:16:23.291300Z

this may not solve your problem with re-frame-10x as it depends on how they refer to the react-highlight library

bhauman 2020-06-16T18:25:55.292700Z

yep that’s a problem the global-export name is react-highlight.js and not react-highlight

2020-06-16T18:27:43.293500Z

Ok, not sure if that’s something they’ll want to change?

2020-06-16T18:27:50.293700Z

Reading your docs =)…

bhauman 2020-06-16T18:28:28.294600Z

yeah my doc’s have little to do with this problem, but they are the result of the problems you had when you tried to get advanced compile working

2020-06-16T18:30:03.296Z

Thanks for the heads up! Yea, that bit of fun ;)…

bhauman 2020-06-16T18:30:20.296400Z

@juhoteperi ^ refering to above shouldn’t react-highlight also be exported as react-highlight so that npm dependency resolution works correctly?

juhoteperi 2020-06-16T21:27:45.298800Z

The npm name is react-highlight.js so the package should be correct