figwheel-main

figwheel-main http://figwheel.org
Sigve 2021-04-08T09:21:22.019700Z

Are reader conditionals (`#?`) not possible to use with figwheel ? I'm getting:

[Figwheel:WARNING] Could not Compile   src/parser/core.cljs   line:477  column:5

  Conditional read not allowed


  475  (defn ^:export parse
  476    [string]
  477    #?(:cljs (clj->js (-parse string))
           ^---
  478       :clj  (-parse string)))


[Figwheel:SEVERE] java.lang.RuntimeException: Conditional read not allowed

2021-04-08T09:24:13.020100Z

they are allowed. file extension should be .cljc

Sigve 2021-04-08T09:28:37.021700Z

Thanks! I just went through the https://clojure.org/guides/reader_conditionals page, but read cljc as cljs

bhauman 2021-04-08T20:43:29.022400Z

@tkjone I’m working on fixes for all the logging problems in 1.10.844

5👍1🙏
athomasoriginal 2021-04-08T20:57:56.022800Z

Excellent! Glad I didn’t start a PR 😅

athomasoriginal 2021-04-08T20:58:43.023200Z

Let me know if you need help testing anything!!

bhauman 2021-04-08T23:05:14.024200Z

@tkjone Just deployed the fixes to 0.2.13-SNAPSHOT

bhauman 2021-04-08T23:05:29.024500Z

let me know if its working for you

bhauman 2021-04-08T23:06:00.024900Z

@raspasov @jkr.sw ^

bhauman 2021-04-08T23:06:19.025100Z

@cassiel ^

athomasoriginal 2021-04-08T23:40:30.027200Z

@bhauman Tested on a new app (will try on a larger existing one a bit later). I see many warnings in the terminal have successfully been resolved and the browser console warning is also resolved. The remaining warnings thrown (3 total) • target/public/cljs-out/dev/figwheel/main/css_reload.cljc - lines 32, 141 and 144 Example:

bhauman 2021-04-08T23:41:48.028Z

oh cool, good to know

bhauman 2021-04-08T23:42:18.028300Z

I’ll fix that up

1👍
athomasoriginal 2021-04-08T23:42:54.029100Z

Tested the HMR and Live Refresh and these are working and the project is configured using autobundle + webpack