figwheel

general discussion about figwheel, specific discussions in #figwheel-main and #lein-figwheel
kommen 2018-03-07T15:07:59.000573Z

we’re running into this problem: https://github.com/bhauman/devcards/issues/99, causing a few hundred lines of warnings for us. I guess this is because devcards.core is injected by figwheel as preloads instead being required?

bhauman 2018-03-07T15:13:36.000049Z

If you require devcards proper instead of just requiring the macros this goes away

bhauman 2018-03-07T15:13:59.000804Z

@kommen

kommen 2018-03-07T15:15:07.000331Z

@bhauman yes, we had that until now, but this resulted in devcards ending up in our prod builds which is undesirable

bhauman 2018-03-07T15:15:43.000635Z

Are you using a preload?

bhauman 2018-03-07T15:16:24.000192Z

so yeah this is an unfortunate trade off and it should only happen on the first build

bhauman 2018-03-07T15:16:42.000573Z

its very tricky to do inline devcards

bhauman 2018-03-07T15:17:08.000652Z

if you move the devcards into there own build this goes away

kommen 2018-03-07T15:17:12.000200Z

yes, we’re using devtools.preload

bhauman 2018-03-07T15:17:36.000642Z

yeah that's not the problem

bhauman 2018-03-07T15:18:06.000383Z

so there is this other method of making this work

bhauman 2018-03-07T15:18:56.000486Z

actually no that wont work

kommen 2018-03-07T15:19:43.000009Z

ok, so you suggest moving defcards to their own namespace which is not included in the prod build?

bhauman 2018-03-07T15:22:51.000604Z

yeah I really do

bhauman 2018-03-07T15:23:23.000623Z

or rather that the trade off for having them inline is those darn warnings

kommen 2018-03-07T15:34:42.000617Z

@bhauman alright, thanks!