Clojurians Log v2

Laziness is the likely culprit. React forces things in dev but not prod.

I’m having some issues figuring out how to store upload percentage in the state db to be used by a component. The code uses amplify-js which takes a callback. I have no issues logging the percentage out but don’t know how to display it in the UI. Any suggestions?

(defn- calculate-upload-progress [progress]
(let [percentage (.floor
                    js/Math
                    (* 100
                    (/ (.-loaded progress)
                        (.-total progress))))]
    (log/debugf "Upload Progress: %d" percentage)))

(defn upload-file
"supports the upload of a single file"
[{:keys [file real-id job-id string-columns job-name app]}]
(go (let [key-path (gstring/format "uploads/%s.json" job-name)
            resp (<p! (.vault.put Storage key-path
                                (js/Blob. #js [file])
                                (clj->js
                                {:metadata         {:string-columns string-columns
                                                    :job-id         (str real-id)}
                                    :progressCallback calculate-upload-progress})))]
        (try
        (comp/transact! app [(update-job-status {:id real-id :url "" :status "Converting..."})])
        (comp/transact! app [(set-loading {:uploading false})])
        (catch js/Error err (js/console.log (ex-cause err)))))))

I am investigating why cljs.pprint is being included in a release build of an app I'm working on. To start out with good known starting state, I cloned the fulcro template from (https://github.com/fulcrologic/fulcro-template) and see that cljs.pprint is included in the release build for the :main build of that template: As far as I can tell pprint is not included anywhere directly in the codebase and there are no obvious indications of namespaces that would include it transitively. I created the report by running: ./node_modules/.bin/shadow-cljs run shadow.cljs.build-report main report.html I'm going to continue removing namespaces from requires to see if I can get pprint removed, but I'm wondering if anyone else ran into this?

I'm not sure, but I think fulcro itself may be including it. I put together a small reproduction here: https://github.com/dvingo/fulcro-release-build-incl-pprint

do you expect expound to be there too? I think that may be coming from guardrails?

I do not expect that to be there -and spec.gen is probably not either. This is for a release build so guardrails should be disabled

cljs.pprint is not DCE capable so just requiring it will keep it in the build, even if otherwise unused

there's this section in the guardrails readme https://github.com/fulcrologic/guardrails#clojurescript-considerations

> > Doing so will prevent you from accidentally generating a release build with guardrails enabled in case you had a shadow-cljs server running in dev mode (which would cache that guardrails was enabled) and built a release target: >

You can try for yourself using that repo - I'd be happy to know if I'm doing something wrong, but there's one namespace in the project so it's hard to see what that would be

guardrails is not even in the dependency list (aside from fulcro including it transitively)

I would also expect other projects to see this showing up

what do you mean? fulcro directly requires guardrails, which means all the dependencies that has will be in your build

disabling guardrails does not change that, it only affects the code the macros generate

hi, newbie question here. is save-middleware the best place to insert business logic such as set the owner of the object to the currently-logged-in user? I want to avoid having to do that on the front end.

using RAD

I am seeing cljs.pprint and expound and fulcro.client-inspect etc show up in the shadow.cljs.build-report for a clojurescript project that uses fulcro. I do not understand why this is happening, so I posted the above git repository to make it easy for others to verify. Just requiring and rendering a fulcro application with one fulcro component results in those extra namespaces showing up in the build report.

Are you saying it is expected that cljs.pprint would show up then? That that is the cost of using fulcro?

if there is something requiring it in the build then yes it is fully expected. I don't know WHAT is requiring it but it seems like it is

you can reconstruct it from the compiler data but there is not function available currently do that for you

got it - thanks for the explanation. I believe a likely candidate is expound: https://github.com/bhb/expound/blob/46b5c84bfe578a81b07c39501a9ed60cfd6ed09f/src/expound/printer.cljc If there isn't much fulcro can do about this perhaps it can at least be documented. It would be good to know if it is intentional or not, or perhaps there is a way to prevent the inclusion of these with some code changes or config changes to one or all of fulcro, guardrails, and expound

my guess would be that it just hasn't been optimized yet, maybe just some namespace reordering would fix it already