funcool

A channel for discussing and asking questions about Funcool libraries https://github.com/funcool/
kenny 2016-05-26T17:12:04.000059Z

FYI in the code example for https://funcool.github.io/catacumba/latest/#server-push pc/response should probably be pc/frame.

niwinz 2016-05-26T17:29:49.000060Z

thanks!

kenny 2016-05-26T17:32:04.000061Z

Also prone plugin is broken with latest catacumba. I think all you need to do is remove the [catacumba.helpers :as hp] require in catacumba.plugins.prone.

kenny 2016-05-26T17:33:43.000062Z

Probably worth updating the deps on the project anyways 🙂

niwinz 2016-05-26T17:45:15.000063Z

0.0! thanks for the notice!

niwinz 2016-05-26T17:45:22.000064Z

I'll fix it ASAP

👍 1
kenny 2016-05-26T17:48:41.000065Z

On a side note.. It'd be nice if you could change this precondition to be (or (keyword? dest) (string? dest)) https://github.com/funcool/postal/blob/master/src/postal/client.cljs#L106. I am writing the backend for an app where the front end is being done in JS (no cljs 😞 ) so it is much easier for the client to send strings to me rather than keywords.

niwinz 2016-05-26T17:49:38.000069Z

Please fill an issue for that. I'm gladly change it

kenny 2016-05-26T17:54:16.000070Z

Made PR https://github.com/funcool/postal/pull/2

niwinz 2016-05-26T18:20:33.000072Z

released 0.7.0 of postal with your change

niwinz 2016-05-26T18:20:42.000073Z

and with other dependencies updates

niwinz 2016-05-26T19:20:48.000074Z

catacumba-prone fixed 😉

👍 1