funcool

A channel for discussing and asking questions about Funcool libraries https://github.com/funcool/
kardan 2016-06-09T15:30:12.000027Z

I tried to set a cookie to a string with an empty space in it. Took a bit to understand why the response was “No response sent for POST request to /login (last handler: catacumba.impl.handlers$eval14933$fn$reify__14935)"

kardan 2016-06-09T15:31:30.000028Z

I realise that it should not be possible, but not sure if it would be possible (or wanted) to have a better error message

kardan 2016-06-09T15:31:39.000029Z

Anyway, just wanted to share

mccraigmccraig 2016-06-09T15:50:55.000030Z

what's happening to the promesa promise.monad namespace @niwinz ? is it moving somewhere else ?

niwinz 2016-06-09T18:04:45.000031Z

@kardan: the error message seems completly unrelated to cookies...

niwinz 2016-06-09T18:04:57.000032Z

it seems you are not returning complete response fom the handler...

niwinz 2016-06-09T18:05:24.000033Z

@mccraigmccraig: it will be moved inside cats directly as it already done with core.async and manifold, just for consistency.

kardan 2016-06-09T18:10:34.000034Z

@niwinz: I have to admit that I only did a quick test. But to me it seemed like adding a cookie where the {:cookiename {:value “token abcqwe”}} would render that error message

niwinz 2016-06-09T18:11:08.000035Z

that error message is printed by ratpack when no response is returned

niwinz 2016-06-09T18:11:31.000036Z

it is completly unrelated to cookes...

niwinz 2016-06-09T18:11:48.000037Z

and is quickly reproducible just not returning a response from a handler

kardan 2016-06-09T18:13:46.000038Z

Maybe I’m confusing myself. Just took up my side project in Catacumba after a period of a lot of other work

niwinz 2016-06-09T18:14:37.000039Z

In any case, if you have some trouble, please let me know I'll try to help you to solve it

kardan 2016-06-09T18:15:29.000040Z

I do have some trouble but I’ll try to look at it with a rested mind first

niwinz 2016-06-09T18:16:36.000041Z

nice!

mccraigmccraig 2016-06-09T18:26:40.000042Z

cool, thanks @niwinz

kardan 2016-06-09T20:23:54.000043Z

@niwinz setting a cookie that includes an empty space, like “a b” will error. See https://github.com/kardan/catacumba/blob/cookies/test/catacumba/core_tests.clj#L52

kardan 2016-06-09T20:24:22.000045Z

Have not had time to look into the reason.