Hi, nice channel 😉. I noticed that you pick up some tips - to avoid tearing your hair out - here is one that took me a while:
To let Graal config the reflector for e.g.
Statementyou need to provide a rule for "[Ljava.sql.Statement". An example is in https://github.com/leafclick/pgmig/blob/master/graal.json
Cheers, see you at :clojureD
Oh, I'll be at :clojureD as well 🙂1👍
could someone provide a straightforward set of instructions to reproduce the CLJ-1472 problem on latest Clojure?
Hiya @alexmiller, we have described the issue on https://github.com/lread/clj-graal-docs/tree/master/CLJ-1472 but steps for reproduction are perhaps a bit buried in all the verbiage. I’ll go and distill and ping back when done.
what we really want is not a fancy script but just a real basic list of how to repro - here's a source file, run x, run y, fails
I'm sure I could do that, but I'm doing 9 other things so it would help :)
sure, am happy to do it
I’ve been away from my happy Clojure place for far too long. Will be nice to dip my toe back.1🙂
you can just attach it to CLJ-1472 if you get to it
uh… was working on it
I'm off for tonight, will attach to CLJ-1472 after ClojureD. Ohh sorry @lee! Maybe you can not look at my repro and see if you come to the same thing 🙂
ya mine was pretty much equivalent.
but more detailed
but yours is good.
if you did it without lein it may be preferable
gotta get some sleep now, giving a talk tomorrow 🙂
mine was just a new page on clj-graal-docs. Less convenient to run than yours but deps based.
have fun! looking forward to videos!1✔️
adding page to clj-graal-docs + clj-1472 seems good, I'll let you finish it
I’ll push and we can compare later. Can always delete.
it should not use lein
deps definitely preferrred
Here’s what I’ve pushed: https://github.com/lread/clj-graal-docs/blob/master/CLJ-1472/steps-to-reproduce.md @alexmiller, I understood you to be looking for raw description rather than scripts, let me know if this is what you had in mind. I’ll wait to review with @borkdude before attaching to CLJ-1472
@lee > Note: A thorough tester will repeat all tests for GraalVM 19.3.1 on JDK11. Let's leave JDK11 out of the equation, it has its own problem with the conditional MethodHandle in clojure.lang.Reflector (documented on the main README.md)
hey go to sleep!
That also has a workaround, but let's only talk about this for now
I’ll update, thanks for feedback
Personally I prefer to just download GraalVM from the downloads page and not install another extra tool like SDKMAN
That’s fine too, but I like SDKMAN! because it lets me switch between versions easily.
Yes, but for a repro it seems unnecessary (same as lein, let's just stick to deps + raw download when possible)
Just describing how I tested.
The rest of the text seems fine to me, excellent job
Now go to sleep! :simple_smile:
thanks very much!
added to ticket
glad to be of use! pushed borkdude’s (notice I did not use the @ on his name because I want him to sleep) feedback.