helix

https://github.com/Lokeh/helix
jimmy 2021-03-11T20:24:29.012600Z

So it looks like use-subscription is a little broken. When I try to use it, even with the test example in the source, it infinite loops. After some debugging, it looks like the react/useEffect doesn’t have the thunk around it. https://github.com/lilactown/helix/blob/f1c211f67785ee2a71a78db76f1b29060145c386/src/helix/hooks.cljc#L340-L341 Pulling that into my project and adding the thunk makes everything work. Happy to make a PR just wanted to write here to make sure I wasn’t missing something.

lilactown 2021-03-11T21:47:19.013Z

whoops lol

lilactown 2021-03-11T21:47:40.013300Z

yes a PR would be appreciated!

jimmy 2021-03-11T22:42:53.013500Z

https://github.com/lilactown/helix/pull/80

🎯 1