Clojurians Log v2
Clojure programming
Channels
Apps
honeysql
Discussion of https://github.com/seancorfield/honeysql :slightly_smiling_face:
2018-09-25T00:42:48.000100Z
2018-09-25T01:17:07.000100Z
2018-09-25T01:22:22.000100Z
2018-09-25T01:43:38.000100Z
2018-09-25T01:43:38.000200Z
2018-09-25T02:03:50.000100Z
2018-09-25T05:26:22.000100Z
2018-09-25T05:53:27.000100Z
richiardiandrea 2018-09-25T16:28:41.000100Z
@seancorfield do you want me or not to contribute the tests above 👆 of course corrected? You closed, does it mean you don't want to test that piece of code? I owe you an apology on sending wrong tests there, I should have put WIP in the PR probably. It was late night. I still think tests make always sense and I can take some spare time for fixing them. What do you think?
seancorfield 2018-09-25T16:42:21.000100Z
Sure, send a corrected PR for additional tests. More tests are always appreciated. Like you say, late night and I was already a bit frustrated with the back and forth on #228 at that point. Sorry.
richiardiandrea 2018-09-25T16:49:40.000100Z
No problem Sean, will do that 😉
richiardiandrea 2018-09-25T16:49:52.000100Z
thanks
2018-09-25T16:56:11.000100Z
2018-09-25T17:06:15.000100Z
2018-09-25T17:06:16.000100Z
2018-09-25T17:07:09.000100Z
seancorfield 2018-09-25T17:07:47.000100Z
Thanks @richiardiandrea
richiardiandrea 2018-09-25T17:08:12.000100Z
thank you for the quick fix
seancorfield 2018-09-25T17:17:18.000100Z
It'll be a while before 0.9.4 comes out -- but at least it has a deps.edn file so you can use it via clj 🙂
richiardiandrea 2018-09-25T18:15:54.000100Z
yep using the SHA right now