honeysql

Discussion of https://github.com/seancorfield/honeysql :slightly_smiling_face:
orestis 2021-04-13T09:34:53.179800Z

Glad to see that honeysql v2 supports DDL statements.

seancorfield 2021-04-13T16:26:19.182300Z

Thanks! @orestis It supports a pretty wide range of things now. I started with what the honeysql-postgres library supported, then added a bunch of additional syntax I found in the PostgreSQL docs (and SQL Server and MySQL docs too) while trying to figure out the correct syntax for the nilenso stuff (instead of trying to read their implementation), then added quite a bit of stuff suggested by folks here, including (and especially) @dharrigan

dharrigan 2021-04-13T16:27:12.183Z

You're most welcome! And thank you for your library! I migrated another service to v2 beta1 today, and only had one gotcha

dharrigan 2021-04-13T16:27:23.183300Z

which thankfully a test caught, otherwise it would have had dire consequences

dharrigan 2021-04-13T16:28:04.183900Z

Perhaps it was a bug in v1 or something in v2, but it caused a AND condition to become an OR condition

dharrigan 2021-04-13T16:28:08.184100Z

which would have blasted out my database.

seancorfield 2021-04-13T16:28:39.184500Z

Oh? Please open an issue on GH if you can.

dharrigan 2021-04-13T16:28:53.184800Z

Would you like to know here first, perhaps it was just my mistake?

dharrigan 2021-04-13T16:28:58.185Z

I can DM you it

dharrigan 2021-04-13T16:29:00.185200Z

if you perfer 🙂

seancorfield 2021-04-13T16:30:58.185400Z

Whatever works for you…

seancorfield 2021-04-13T20:04:45.186200Z

com.github.seancorfield/honeysql {:mvn/version "2.0.0-beta2"} — includes an important bug fix uncovered by @dharrigan — thank you!